Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Global Multiplier when set to 0 (resolves #23) #24

Merged
merged 5 commits into from
Feb 20, 2024
Merged

Conversation

jvivian
Copy link
Owner

@jvivian jvivian commented Feb 20, 2024

  • Consolidate codebase's run-model function into core library
  • Fix minor parameter menu bug in Factor Analysis
  • Add test for global-multiplier-0

Copy link

codecov bot commented Feb 20, 2024

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (e338cc0) 87.5% compared to head (b5cc8eb) 75.2%.

Files Patch % Lines
covid19_drdfm/dfm.py 82.1% 4 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##            main     #24      +/-   ##
========================================
- Coverage   87.5%   75.2%   -12.3%     
========================================
  Files          5       5              
  Lines        168     182      +14     
  Branches      30      35       +5     
========================================
- Hits         147     137      -10     
- Misses        18      44      +26     
+ Partials       3       1       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jvivian jvivian merged commit 0339eb8 into main Feb 20, 2024
5 of 7 checks passed
@jvivian jvivian deleted the fix-global-0 branch February 28, 2024 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant