-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make Sonatype the default publisher #14
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have anything to really review here.. But I'd like to exress my personal opinion about this change. It's not obvious to me that Sonatype publisher is strictly better and should be default one in this plugin.
Here's what the docs say about disadvantages of both publishers: Sonatype
Bintray
I think "It requires an extra account" is equally applicable to Sonatype. Also, I think it's assumed here that everyone wants to publish to Maven Central.
What is meant here? Setting your Bintray user/repo or something else? Doesn't sbt-sonatype require any setup at all? |
What I meant by "it requires an extra account" is that if you want to release to Central, you need both a Bintray and a Sonatype account, while you only need one if you do the Sonatype way. The real bad thing is that asking for permission to sync up with Maven Central has to be done per package, and it does take a non-negligible amount of time (from one to three days). This is done per package. In Sonatype, you only ask for permission to release to Maven Central once, for all packages.
What I meant is that if you do not release to Central, you need to set up a bintray resolver to get the packages. You force this to your users, so I think it's always better to release to Central. Another thing against Bintray is that they have limits on the amount of binaries you can publish, and if you surpass those limits they will "suspend" your account and ask you to pay. This has happened with the sbt Bintray account. |
Oops, it seems I closed this by mistake. Lemme know whether my reply makes any sense. |
@laughedelic Okay Alexey, if you don't have anything else to add, I'm merging 😄. |
Sorry, I didn't have time to reply. But you should merge anyway. I just want the docs to be more fair describing disadvantages of both options. You brought some good points showing why Bintray is not the best default option. |
This is a change I wanted to do some time ago, but waited for the perfect
moment to bump up the major version number. My experience releasing tells me to
recommend Sonatype, and therefore I want to make it the default publisher.
This will require a change in the docs.