Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow override placeholders #103

Merged

Conversation

AndrewChubatiuk
Copy link

@AndrewChubatiuk AndrewChubatiuk commented Sep 27, 2023

Hi
Thank you for a project. I made an ability to override template placeholders to be make helm configuration more readable instead of having {{'{{'}} value {{'}}'}}

Copy link
Member

@dewey dewey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, I just added two small comments :)

config.go Outdated
func getenv(key, defaultVal string) string {
if val, found := os.LookupEnv(key); found {
return val
} else {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can get rid of the else there and just unindent the return.

config.go Show resolved Hide resolved
@AndrewChubatiuk
Copy link
Author

@dewey done

@dewey
Copy link
Member

dewey commented Sep 28, 2023

Looks good, I'm going to merge it. Thanks for the contribution!

@dewey dewey merged commit b51b1ff into justwatchcom:master Sep 28, 2023
1 check passed
@dewey
Copy link
Member

dewey commented Sep 28, 2023

@AndrewChubatiuk AndrewChubatiuk deleted the allow-override-placeholders branch September 28, 2023 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants