feat: custom extension for resolveFullPath and add regex for minified js #203
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, this library is all I need. Using it with esbuild is great combo. But I miss something
First, when the target files is minified version (esbuild minify=true), then It will not replace anything. Because minified version is look like this
As you can see, there is no space after import and from statement. I add regex to cover this situation, please correct me is the regex can be simplified.
Second, when using
resolveFullPath
option, this library only search for.js
extension. My project is full esm, it's using.mjs
. So I create additional option to cover this, so It can be adjusted to search.mjs
or.cjs
. By default it will search.js
. I don't know if it's the best way.