Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make foreground color bold #349

Merged
merged 1 commit into from
Apr 20, 2022
Merged

make foreground color bold #349

merged 1 commit into from
Apr 20, 2022

Conversation

buckley310
Copy link
Contributor

As asked in #84

Does anyone dislike the idea of just making the font always bold? It looks better in my opinion, and it seems to be the norm for most powerline setups. (https://www.google.com/search?q=powerline+bash&tbm=isch)

I've been carrying this patch for a while on my PCs.
image
First prompt is current behavior. Second prompt is with the bold patch.

@justjanne justjanne merged commit 8abe07a into justjanne:main Apr 20, 2022
@scop
Copy link
Contributor

scop commented Apr 20, 2022

Does anyone dislike the idea of just making the font always bold?

I do :) Unfortunately I only found out about this change now. No single choice fits all tastes and this stuff is highly subjective, but in my opinion, making it bold makes the prompt somewhat harder to read and stand out too much -- the really important stuff on the console is not what what's in the prompt but between them.

I've been carrying this patch for a while on my PCs.

It seems it's my turn to start carrying the revert patch around until some other solution is found :P

@buckley310
Copy link
Contributor Author

I'll see if I can work out how to integrate boldness into the themes stuff. I've thrown a few minor patches over the wall, maybe it's time for a larger one 😅. The only perfect solution is to make boldness configurable per-segment, I agree one style will never be best for everyone.

@justjanne
Copy link
Owner

I integrated it into the themes and changed the default back to not be bold :)

@buckley310 buckley310 deleted the bold branch April 22, 2022 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants