Skip to content

Commit

Permalink
Fix lint task in CI
Browse files Browse the repository at this point in the history
The lint task was failing at head, due to a nolint:exhaustive error
directive that golangci nolintlint believes is unused.

Issue seems to be golangci/golangci-lint#3228
and seems to be a bug in golang-ci / nolintlint.
  • Loading branch information
justinsb committed Mar 20, 2023
1 parent ce3e394 commit 6bdbdb7
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 2 deletions.
2 changes: 1 addition & 1 deletion api/internal/builtins/HelmChartInflationGenerator.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion api/internal/localizer/builtinplugins.go
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,6 @@ func (lbp *localizeBuiltinPlugins) localizeAll(node *yaml.RNode) error {
// We rely on the build command to throw errors for nodes in
// built-in plugins that are sequences when expected to be scalar,
// and vice versa.
//nolint: exhaustive
switch node.YNode().Kind {
case yaml.SequenceNode:
return errors.Wrap(node.VisitElements(lbp.localizeScalar))
Expand Down

0 comments on commit 6bdbdb7

Please sign in to comment.