label-mode: use virtual text in nvim ≥ 0.5 #303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
tomtomjhj
commented
Jul 11, 2023
tomtomjhj
commented
- label-mode: remove workaround for old vim bug
- This is not necessary. But 7.4.792 dates back to 2015, so I think it's fine to remove.
- label-mode: replace conceal with virtual text in nvim ≥ 0.5
Problem: Using conceal for label interferes with usual syntax highlights that use conceal. Solution: In nvim, set decoration provider that renders labels as virtual text only in the current window.
|
This is great, thank you! Looks great, also not much new code, and no regressions in the tests. So merging now. But I noticed one issue: changing the SneakLabel highlight isn't fully respected. Example: |
justinmk
changed the title
This was referenced Aug 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.