Fix transliteration and add types #84
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Transliteration was still in python2 mode and never upgraded. Since this module should no longer support python 2.x rewrite it to python 3. Python 3's join() doesn't allow you to combine bytes and str, so we have to encode the delimiter as well. Last but not least, document how translitcodec works, so we don't have to find this out the hard way. Also type this module. Utils are only used internally, but type them anyway as they can be referenced trough dotted notation in settings or people may import and use some of the functions here.
- Unfortunately coverage doesn't know about TYPE_CHECKING - We don't care about delete's signature, so just use kwargs for forwards compatibility - Upgrade coverage to latest
|
@justinmayer Do you want this fixed or since the code wasn't python3 compatible and no one complained since python2 died, remove it? |
|
Even though I’m not aware of any complaints about it, I think the transliteration features could be useful enough to keep around if it’s not too much trouble. What do you think? |
|
+1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Transliteration was still in python2 mode and never upgraded. Since this module should no longer support python 2.x rewrite it to python 3.
Python 3's join() doesn't allow you to combine bytes and str, so we have to encode the delimiter as well.
Last but not least, document how translitcodec works, so we don't have to find this out the hard way.
Also type this module.
Utils are only used internally, but type them anyway as they can be referenced trough dotted notation in settings or people may import and use some of the functions here.
Chores: