Skip to content
This repository has been archived by the owner on Sep 30, 2024. It is now read-only.

Fix fk text cols #135

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

lmeyer1
Copy link
Contributor

@lmeyer1 lmeyer1 commented Oct 19, 2020

Description

This fixes two bugs:

  • Text columns do not have a dimension. create table statements containing a textor ntext column were not valid
  • The script could not handle foreign key spanning multiple columns.

Checklist

Please ensure your pull request fulfills the following requirements:

  • The commit messages follow our guidelines (CONTRIBUTING.md).
  • Tests for any changes have been added (for bug fixes / features).
    I tested the changes with our database, and it works.
    For a general test, we would need a test database with tables implementing those features. Unfortunately I don't know how you set up testing.
  • Docs have been added / updated (for bug fixes / features).
    There's nothing that has changed that needs to be documented.

Type

What kind of change does this pull request introduce?

[x] Bug fix.
[ ] Feature.
[ ] Code style update (formatting, local variables).
[ ] Refactoring (no functional changes, no api changes).
[ ] Build related changes.
[ ] CI related changes.
[ ] Documentation content changes.
[ ] Other (please describe below).

Breaking Changes

Does this pull request introduce any breaking changes?

[ ] Yes
[x] No

The generated scripts differ from previous versions in these three points:

  • create table statements containing text columns are now valid
  • add foreign key statements spanning multiple columns are now valid
  • for tables with more than one foreign key constraints, the order of the foreign keys in the generated might differ. It did not happen in my case (about 10 databases with more than 400 tables each).

Other Information

n/a

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant