Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: dsw-2308-radio-styles integration #215

Merged
merged 4 commits into from
Oct 11, 2024
Merged

feat: dsw-2308-radio-styles integration #215

merged 4 commits into from
Oct 11, 2024

Conversation

pie-design-system-bot
Copy link
Contributor

@pie-design-system-bot pie-design-system-bot commented Oct 3, 2024 •
edited by jamieomaguire
Loading

  • Updates to latest radio styles
  • Adds strong typing to the form data used by tests
  • Fixes the vanilla system test

@jamieomaguire jamieomaguire reopened this Oct 9, 2024
@jamieomaguire jamieomaguire marked this pull request as ready for review October 10, 2024 07:51
@jamieomaguire
Copy link
Contributor

There is some funkiness with the radio styles and timing of the screenshot. This is known and there is a bug ticket created. It shouldn't block this PR from updating Aperture to latest 😃

@jamieomaguire jamieomaguire merged commit e753385 into main Oct 11, 2024
35 checks passed
@jamieomaguire jamieomaguire deleted the dsw-2308-radio-styles branch October 11, 2024 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raoufswe raoufswe raoufswe approved these changes

@fernandofranca fernandofranca fernandofranca approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pie-design-system-bot @jamieomaguire @fernandofranca @raoufswe