Publish pre-release packages to github packages #784
Conversation
ghost
requested a review
from 
Codecov Report
@@ Coverage Diff @@
## master #784 +/- ##
==========================================
- Coverage 82.01% 81.79% -0.22%
==========================================
Files 108 108
Lines 2758 2758
==========================================
- Hits 2262 2256 -6
- Misses 496 502 +6
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Co-authored-by: Martin Costello <[email protected]>
Ah fair - it looks like there's some reasonable docs around it now. Shall we merge it and see if we can get master pushing to packages? |
Co-authored-by: Martin Costello <[email protected]>
|
Happy to merge to try it once it's green, but if it fails you might need to do a follow up to just comment it out. |
Yep going to timebox this and revert it if I can't get it working 😁 |
|
I'm going to just set |
|
Great idea. Who do we beg to make GitHub NuGet feeds public? |
They are public here, we just haven't published any yet :) |
|
No way, ok that's awesome! I thought GH had them private only, which would be a pain. |
We're good for public - for private, someone in the finance/procurement sphere will have to change the billing plan. |
|
I don't understand why the coverage is failing now - it seems to think there are changes where there aren't any 🙃
|
|
The builds aren't 100% deterministic, so the coverage varies. Note that the coverage statuses aren't required. |
Oh righto, awesome. In that case this PR just needs your green tick please, and we can try it out :) |
Co-authored-by: Martin Costello <[email protected]>
|
Looks like the same sort of problems I was getting, where the responses aren't helpful at all: https://github.com/justeat/JustSaying/runs/1091741953?check_suite_focus=true#step:8:8 |
|
Hmmm, if we want to keep going down this route, it looks like we might need to authenticate with GPR before attempting the push, as described here. There's an open issue on NuGet with sending the API key directly: NuGet/Home#8580. |
|
@martincostello we explicitly specify nuget when pushing there so I think we could set this up and regular nuget push should still work |
|
You can try that too, but I did a lot of banging my head against a wall trying to get all this working including explicitly configuring NuGet.exe and the .NET Core SDK 😅 |
Yeah I'm ready to give up if this PR doesn't work |
Shall we try Github packages for pre-releases to make consuming them from tooling a little nicer than the zip artifacts?