Fixes and refactors #550
Merged
Fixes and refactors #550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove leftover code from previous refactors.
Try and fix integration tests failing if tasks transition so they're already completed.
Update various NuGet pacakges to their latest versions.
Change timeout constructor parameter to a TimeSpan. This makes the unit clearer and removes the need to create a new TimeSpan for every message invocation. Compute the message lock key suffix once, rather than per message invocation, as it does not change for the lifetime of the handler.
Do a reflection call to get the inner handler's type once per instance, rather than once per message.
Use a local function for the worker task, rather than explicitly creating a Func<Task>.
Make field readonly as its value is never reassigned.
Reduce the number of calls to message.GetType(). Change logger overloads to not specify an event Id of zero.
Change log overloads used to not specify an event Id of zero. Reduce calls to message.GetType(). Include receipt handle in log message.
Ensure that the MessageContext is reset to null if an exception is thrown when updating the message visibility timeout.
Codecov Report
@@ Coverage Diff @@
## master #550 +/- ##
==========================================
+ Coverage 37.64% 38.12% +0.48%
==========================================
Files 78 78
Lines 2614 2662 +48
Branches 461 465 +4
==========================================
+ Hits 984 1015 +31
- Misses 1485 1498 +13
- Partials 145 149 +4
Continue to review full report at Codecov.
|
slang25
reviewed
Jun 30, 2019
slang25
approved these changes
Jul 1, 2019
iancooper
approved these changes
Jul 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick changes from #546 and #549 to:
ExactlyOnceHandlerto aTimeSpan. This makes the unit clearer and removes the need to create a newTimeSpanfor every message invocation.ExactlyOnceHandleronce, rather than per message invocation, as it does not change for the lifetime of the handler.StopwatchHandlerto get the inner handler's type once per instance, rather than once per message.Func<Task>.readonlyas its value is never reassigned.message.GetType()in various places.MessageContextis reset tonullif an exception is thrown when updating the message visibility timeout.