Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix multiple-select dropdown to remain open after selection #236

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

vishwamartur
Copy link

@vishwamartur vishwamartur commented Nov 4, 2024

Related to #214

Update MultipleSelect component to keep the dropdown open after selection.

  • Add shouldCloseOnBlur={false} to Popover.Picker to prevent closing on blur.
  • Modify onSelectionChange function to keep the dropdown open after setting the selected key and input value.

Related to justdlabs#214

Update `MultipleSelect` component to keep the dropdown open after selection.

* Add `shouldCloseOnBlur={false}` to `Popover.Picker` to prevent closing on blur.
* Modify `onSelectionChange` function to keep the dropdown open after setting the selected key and input value.

---

For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/justdlabs/justd/issues/214?shareId=XXXX-XXXX-XXXX-XXXX).
@irsyadadl
Copy link
Collaborator

irsyadadl commented Nov 4, 2024

@vishwamartur

Tested, but it doesn't work. Still closed when choose a item. Did you test it? Property shouldCloseOnBlur does not exist on type

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants