-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Patch for UHD HDR10 and HDR10+ #70
Conversation
This patch cleans up the confusion between "hrd" (which is the "hypothetical reference decoder" in H265 standard) and "HDR" (header, or High Dynamic Range)
It looks like these changes conflict with some of the changes @xavery introduced in #67 Can you please take a look at how to resolve these conflicts? |
Grr... I have to replace most "virtual" with "overrides". Will do !! |
Update h264StreamReader.h
Update vc1StreamReader.h
@justdan96 the only conflicts left are the integration of functions getStreamHDR() in the four StreamReaders. Nothing else I can do on my side. |
As the UHD BD type is set to 66/100 GB / Default Transfer Rate 123 Mbps, TS_recording_rate has to be changed to 13625000 for UHD.
The "(byte)" passes on MSVC but fails on gcc
The "(byte)" passes on MSVC but fails on gcc
As advised by @xavery
As advised by @xavery
As advised by @xavery
As advised by @xavery
As suggested by @xavery
As advised by @xavery
Deserialize override, as per @xavery pull request #67
@jcdr428 I'm fine with merging these changes once you're confident that enough testing has been done. |
@xavery thanks. jdobbs and I have tested this HDR10 patch quite a lot, and it is working well. So in brief, yes I am confident that enough testing has been done to merge this change. |
I've tested on few SDR and HDR10 Blu-rays without issues.
The patch would need to be thoroughly tested by some other users (eg offer an alternative build for testing) before integration to Master.