Skip to content

Commit

Permalink
Merge pull request codeigniter4#8601 from kenjis/fix-duplicate-cache-…
Browse files Browse the repository at this point in the history
…control-header

fix: duplicate Cache-Control header with Session
  • Loading branch information
kenjis authored Mar 9, 2024
2 parents fd28a3f + a30e130 commit bcb88b4
Showing 1 changed file with 6 additions and 0 deletions.
6 changes: 6 additions & 0 deletions system/Config/Services.php
Original file line number Diff line number Diff line change
Expand Up @@ -690,6 +690,12 @@ public static function session(?SessionConfig $config = null, bool $getShared =
$session->setLogger($logger);

if (session_status() === PHP_SESSION_NONE) {
// PHP Session emits the headers according to `session.cache_limiter`.
// See https://www.php.net/manual/en/function.session-cache-limiter.php.
// The headers are not managed by CI's Response class.
// So, we remove CI's default Cache-Control header.
AppServices::response()->removeHeader('Cache-Control');

$session->start();
}

Expand Down

0 comments on commit bcb88b4

Please sign in to comment.