Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Spotify playback functionality via SMTC #30

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

00Chaotic
Copy link

I'm also not usually a C++ developer and this is my first foray into Cyberpunk modding (why are there so many core mods doing seemingly similar things) so I'd appreciate any feedback or suggestions for improvement :)


This change adds a default Spotify Radio station that allows for playback on the actual Spotify app. Requires the Spotify app to be open, and then it plays/pauses automatically. The in-game radio station volume controls will not work, so the user must change the volume through the Spotify app. I've done some basic testing, as shown in the video below, but more thorough testing is still needed.

Video of the functionality

The above video doesn't capture the SMTC overlay, which displays when playing/pausing playback:
image

Visualised readme changes for convenience:
image

@00Chaotic
Copy link
Author

@justarandomguyintheinternet not sure how the notifications work so I'm tagging you in hopes you see this :)

@00Chaotic
Copy link
Author

I've realised this implementation requires the user to have Windows SDK installed. I assume it's an issue with the way I'm compiling the RadioExt.dll, but as mentioned I'm unfamiliar with C++ so I would appreciate some assistance when you have time. If I manage to solve the issue before then, I'll mention it here.

@00Chaotic 00Chaotic force-pushed the add-spotify-playback branch from aba6701 to 5d857d1 Compare October 2, 2024 11:48
@00Chaotic 00Chaotic force-pushed the add-spotify-playback branch from 5d857d1 to 1d19449 Compare October 2, 2024 11:50
@00Chaotic
Copy link
Author

I believe I've fixed it. I've also changed to using the newer SendInput() function instead of the deprecated keybd_event() which would be more secure and robust.

@00Chaotic
Copy link
Author

@justarandomguyintheinternet bumping this for (likely) the last time. I've finished my playthrough of the game and don't plan on further playing/modding the game.

I'm unsure if the 2.2 update has affected this change but I imagine if the rest of the mod is fine then this should be too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant