Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Provide a devShell with packages from enabled services #355

Merged
merged 6 commits into from
Oct 10, 2024

Conversation

shivaraj-bh
Copy link
Member

resolves #194

@shivaraj-bh shivaraj-bh changed the title feat(devShell): Output a shell with packages of all the enabled services feat(devShell): Output a shell with packages from enabled services Oct 9, 2024
@shivaraj-bh shivaraj-bh changed the title feat(devShell): Output a shell with packages from enabled services feat: Provide a devShell with packages from enabled services Oct 9, 2024
@shivaraj-bh shivaraj-bh requested a review from srid October 9, 2024 12:48
Copy link
Member

@srid srid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with these changes.

nix/services/default.nix Show resolved Hide resolved
nix/services/default.nix Outdated Show resolved Hide resolved
nix/services/default.nix Outdated Show resolved Hide resolved
Copy link
Member

@srid srid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, can merge after this type change.

nix/services/devshell.nix Outdated Show resolved Hide resolved
@shivaraj-bh shivaraj-bh merged commit 6e1251b into main Oct 10, 2024
2 checks passed
@shivaraj-bh shivaraj-bh deleted the devshell-output branch October 10, 2024 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Have services provide the relevant devShell?
2 participants