Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(stripe): return all the missing fields in a request #935

Merged
merged 25 commits into from
May 2, 2023
Merged

refactor(stripe): return all the missing fields in a request #935

merged 25 commits into from
May 2, 2023

Conversation

jeevaprakashdr
Copy link
Contributor

@jeevaprakashdr jeevaprakashdr commented Apr 20, 2023 •
edited by SanchithHegde
Loading

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates

Description

On address field validation return all the mandatory fields having a null or empty values.

Additional Changes

  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

Closes #451.

How did you test it?

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@jeevaprakashdr jeevaprakashdr mentioned this pull request Apr 20, 2023
Closed
2 tasks
@SanchithHegde SanchithHegde changed the title Feature 451 return all the missing fields in a request feat: return all the missing fields in a request Apr 20, 2023
SanchithHegde
SanchithHegde reviewed Apr 20, 2023
View reviewed changes
Copy link
Member

@SanchithHegde SanchithHegde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR, @jeevaprakashdr!
Other than the minor changes I've requested, this PR looks good to me!

Regarding the signal-hook-tokio changes included here for the project to compile on Windows, @NishantJoshi00 I'll need your opinion on how we should proceed.

crates/router/src/connector/stripe/transformers.rs Outdated Show resolved Hide resolved
crates/router/src/connector/stripe/transformers.rs Outdated Show resolved Hide resolved
crates/router/src/core/errors.rs Outdated Show resolved Hide resolved
@SanchithHegde SanchithHegde added A-connector-integration Area: Connector integration S-waiting-on-author Status: This PR is incomplete or needs to address review comments C-refactor Category: Refactor labels Apr 20, 2023
@SanchithHegde SanchithHegde removed S-ready-for-merge S-needs-conflict-resolution Status: This PR needs conflicts to be resolved by the author labels Apr 25, 2023
jeevaprakashdr and others added 2 commits April 25, 2023 14:11
@jeevaprakashdr @vspecky
Update macro suggestion
0786378 
Co-authored-by: ItsMeShashank <[email protected]>
@jeevaprakashdr @vspecky
inferred variable type
83dc839 
Co-authored-by: ItsMeShashank <[email protected]>
@SanchithHegde
Copy link
Member

@jeevaprakashdr Once you're done with the macro renaming, please address the failing CI checks.

@jeevaprakashdr jeevaprakashdr force-pushed the feature_451_return_all_the_missing_fields_in_a_request branch from 274c9a1 to ce164d0 Compare April 25, 2023 19:51
@SanchithHegde SanchithHegde added S-waiting-on-review Status: This PR has been implemented and needs to be reviewed S-waiting-on-author Status: This PR is incomplete or needs to address review comments and removed S-waiting-on-author Status: This PR is incomplete or needs to address review comments S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Apr 25, 2023
@jeevaprakashdr jeevaprakashdr force-pushed the feature_451_return_all_the_missing_fields_in_a_request branch from ce164d0 to e5a3322 Compare April 25, 2023 21:24
SanchithHegde
SanchithHegde reviewed Apr 26, 2023
View reviewed changes
crates/router/Cargo.toml Outdated Show resolved Hide resolved
crates/router/src/connector/stripe/transformers.rs Outdated Show resolved Hide resolved
@jeevaprakashdr jeevaprakashdr force-pushed the feature_451_return_all_the_missing_fields_in_a_request branch from e5a3322 to f8254b0 Compare April 26, 2023 20:26
SanchithHegde
SanchithHegde approved these changes Apr 26, 2023
View reviewed changes
Copy link
Member

@SanchithHegde SanchithHegde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Thanks again for this PR, @jeevaprakashdr!

crates/common_utils/Cargo.toml Show resolved Hide resolved
@SanchithHegde SanchithHegde added S-waiting-on-review Status: This PR has been implemented and needs to be reviewed and removed S-waiting-on-author Status: This PR is incomplete or needs to address review comments labels Apr 26, 2023
Narayanbhat166
Narayanbhat166 approved these changes Apr 28, 2023
View reviewed changes
Copy link
Member

@Narayanbhat166 Narayanbhat166 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good to me! Cheers @jeevaprakashdr 🚀

@Narayanbhat166 Narayanbhat166 added S-ready-for-merge and removed S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Apr 28, 2023
@jarnura jarnura added this pull request to the merge queue May 2, 2023
Merged via the queue into juspay:main with commit e9fc34f May 2, 2023
@Narayanbhat166 Narayanbhat166 mentioned this pull request May 3, 2023
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SanchithHegde SanchithHegde SanchithHegde approved these changes

@NishantJoshi00 NishantJoshi00 NishantJoshi00 approved these changes

@Narayanbhat166 Narayanbhat166 Narayanbhat166 approved these changes

@vspecky vspecky vspecky approved these changes

@jarnura jarnura jarnura approved these changes

@ashokkjag ashokkjag Awaiting requested review from ashokkjag

Assignees

@jeevaprakashdr jeevaprakashdr

Labels
A-connector-integration Area: Connector integration C-refactor Category: Refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE] return all the missing_fields in a request
6 participants
@jeevaprakashdr @SanchithHegde @jarnura @vspecky @Narayanbhat166 @NishantJoshi00