-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] return all the missing_fields
in a request
#451
Comments
missing_fields
in a requestmissing_fields
in a request
missing_fields
in a requestmissing_fields
in a request
@Narayanbhat166 I am happy to have a look at this. Please can you assign to me? |
Hi @jeevaprakashdr. To provide more context on where this would be helpful, have a look at this function
This validates the shipping_address to check whether all necessary fields are present or not. But if some field is missing, it will throw back an error. A better experience would be to return all the missing required fields at once.
A possible implementation would be to create a new error type which returns a vector of missing fields. |
@Narayanbhat166 Thank you for reaching out. I am just seeing your message. The task has been completed and soon will create a PR |
That's great. Please mention the PR number here, once created |
@Narayanbhat166 here is the PR-935 Please note, there are changes related to application setup in Windows OS. |
Feature Description
During address validation, It would be a good experience to have all the missing fields returned at once instead of making many requests to know the missing fields.
Referring the discussion here #441 (comment)
Possible Implementation
A separate error type could be implemented which will take a vector or missing fields and return it.
Have you spent some time to check if this feature request has been raised before?
Have you read the Contributing Guidelines?
Are you willing to submit a PR?
Yes I am willing to submit a PR!
The text was updated successfully, but these errors were encountered: