Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] return all the missing_fields in a request #451

Closed
2 tasks done
Narayanbhat166 opened this issue Jan 22, 2023 · 5 comments · Fixed by #935
Closed
2 tasks done

[FEATURE] return all the missing_fields in a request #451

Narayanbhat166 opened this issue Jan 22, 2023 · 5 comments · Fixed by #935
Assignees
Labels
C-feature Category: Feature request or enhancement good first issue Good for newcomers help wanted Extra attention is needed

Comments

@Narayanbhat166
Copy link
Member

Narayanbhat166 commented Jan 22, 2023

Feature Description

During address validation, It would be a good experience to have all the missing fields returned at once instead of making many requests to know the missing fields.

Referring the discussion here #441 (comment)

Possible Implementation

A separate error type could be implemented which will take a vector or missing fields and return it.

Have you spent some time to check if this feature request has been raised before?

  • I checked and didn't find similar issue

Have you read the Contributing Guidelines?

Are you willing to submit a PR?

Yes I am willing to submit a PR!

@Narayanbhat166 Narayanbhat166 added C-feature Category: Feature request or enhancement S-awaiting-triage Status: New issues that have not been assessed yet labels Jan 22, 2023
@Narayanbhat166 Narayanbhat166 self-assigned this Jan 22, 2023
@Narayanbhat166 Narayanbhat166 changed the title return all the missing_fields in a request [Feature] return all the missing_fields in a request Apr 12, 2023
@Narayanbhat166 Narayanbhat166 changed the title [Feature] return all the missing_fields in a request [FEATURE] return all the missing_fields in a request Apr 12, 2023
@Narayanbhat166 Narayanbhat166 added good first issue Good for newcomers help wanted Extra attention is needed and removed S-awaiting-triage Status: New issues that have not been assessed yet labels Apr 13, 2023
@jeevaprakashdr
Copy link
Contributor

@Narayanbhat166 I am happy to have a look at this. Please can you assign to me?

@Narayanbhat166
Copy link
Member Author

Narayanbhat166 commented Apr 14, 2023

Hi @jeevaprakashdr. To provide more context on where this would be helpful, have a look at this function

fn validate_shipping_address_against_payment_method(

This validates the shipping_address to check whether all necessary fields are present or not. But if some field is missing, it will throw back an error. A better experience would be to return all the missing required fields at once.

A possible implementation would be to create a new error type which returns a vector of missing fields.

@jeevaprakashdr
Copy link
Contributor

jeevaprakashdr commented Apr 20, 2023

@Narayanbhat166 Thank you for reaching out. I am just seeing your message. The task has been completed and soon will create a PR

@Narayanbhat166
Copy link
Member Author

Narayanbhat166 commented Apr 20, 2023

That's great. Please mention the PR number here, once created

@jeevaprakashdr
Copy link
Contributor

@Narayanbhat166 here is the PR-935

Please note, there are changes related to application setup in Windows OS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-feature Category: Feature request or enhancement good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants