Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

om health: Improve tracing message for flake URL #351

Merged
merged 1 commit into from
Nov 18, 2024

Conversation

Adda0
Copy link
Contributor

@Adda0 Adda0 commented Nov 17, 2024

This PR adds a missing parenthesis to a tracing message and, when at it, pretty prints the flake URL instead of leaking the Rust debug print of Some(FlakeUrl(...)) or None to the user. This output is consistent with the Flake field in the printed table below.
Previously (note the missing ending parenthesis):

$ om health
...
🩺 Checking the health of your Nix setup (flake=None
...

and

$ om health "github:juspay/nixos-unified-template"
...
🩺 Checking the health of your Nix setup (flake=Some(FlakeUrl(github:juspay/nixos-unified-template))
...

Now:

$ om health
...
🩺 Checking the health of your Nix setup (flake: 'N/A')
──────────────────────────
 Property    Value
──────────────────────────
 Flake       N/A
...

and

$ om health "github:juspay/nixos-unified-template"
...
🩺 Checking the health of your Nix setup (flake: 'github:juspay/nixos-unified-template')
──────────────────────────────────────────────────
 Property    Value
──────────────────────────────────────────────────
 Flake       github:juspay/nixos-unified-template
...

cargo test fails on some unrelated issue which fails on master as well.

@srid
Copy link
Member

srid commented Nov 18, 2024

Thanks!

@srid srid merged commit af87950 into juspay:main Nov 18, 2024
5 checks passed
@Adda0 Adda0 deleted the om-health-typo branch November 18, 2024 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants