Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(api_models): derive Serialize, Eq, PartialEq, strum::Display on RefundStatus #989

Merged
merged 12 commits into from
May 2, 2023
Merged

feat(api_models): derive Serialize, Eq, PartialEq, strum::Display on RefundStatus #989

merged 12 commits into from
May 2, 2023

Conversation

JeevaRamu0104
Copy link
Contributor

@JeevaRamu0104 JeevaRamu0104 commented Apr 26, 2023 •
edited
Loading

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@JeevaRamu0104 JeevaRamu0104 requested a review from a team as a code owner April 26, 2023 07:28
@JeevaRamu0104 JeevaRamu0104 self-assigned this Apr 26, 2023
@JeevaRamu0104 JeevaRamu0104 added A-core Area: Core flows C-feature Category: Feature request or enhancement E-easy Effort: Should be easy to implement and would make a good first PR R-waiting-on-L1 Review: Waiting on L1 reviewer labels Apr 26, 2023
@JeevaRamu0104 JeevaRamu0104 added the S-waiting-on-review Status: This PR has been implemented and needs to be reviewed label Apr 26, 2023
lsampras
lsampras previously approved these changes Apr 26, 2023
View reviewed changes
@lsampras lsampras added R-waiting-on-L2 Review: Waiting on L2 reviewer R-L1-completed Review: L1 Review completed and removed R-waiting-on-L1 Review: Waiting on L1 reviewer labels Apr 26, 2023
@SanchithHegde SanchithHegde changed the title Fix(analytics):add-derive-refund-status feat(api_models): derive Serialize, Eq, PartialEq, strum::Display on RefundStatus Apr 26, 2023
SanchithHegde
SanchithHegde previously approved these changes Apr 26, 2023
View reviewed changes
@JeevaRamu0104 JeevaRamu0104 requested a review from a team as a code owner May 2, 2023 07:29
@JeevaRamu0104 JeevaRamu0104 dismissed stale reviews from SanchithHegde and lsampras via cfbfa1a May 2, 2023 07:45
jarnura
jarnura previously approved these changes May 2, 2023
View reviewed changes
@jarnura jarnura added S-waiting-on-author Status: This PR is incomplete or needs to address review comments and removed S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels May 2, 2023
@JeevaRamu0104 JeevaRamu0104 requested a review from a team as a code owner May 2, 2023 08:08
@SanchithHegde SanchithHegde added S-waiting-on-author Status: This PR is incomplete or needs to address review comments S-waiting-on-review Status: This PR has been implemented and needs to be reviewed and removed S-waiting-on-author Status: This PR is incomplete or needs to address review comments labels May 2, 2023
@jarnura jarnura added S-ready-for-merge and removed S-waiting-on-review Status: This PR has been implemented and needs to be reviewed R-waiting-on-L2 Review: Waiting on L2 reviewer labels May 2, 2023
@lsampras lsampras added this pull request to the merge queue May 2, 2023
Merged via the queue into main with commit 22a5372 May 2, 2023
@SanchithHegde SanchithHegde deleted the fix/refund-status-eq-dervie branch May 2, 2023 12:31
@SanchithHegde SanchithHegde removed S-ready-for-merge R-L1-completed Review: L1 Review completed E-easy Effort: Should be easy to implement and would make a good first PR labels May 2, 2023
@Narayanbhat166 Narayanbhat166 mentioned this pull request May 3, 2023
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SanchithHegde SanchithHegde SanchithHegde approved these changes

@lsampras lsampras lsampras approved these changes

@jarnura jarnura jarnura approved these changes

@Abhicodes-crypto Abhicodes-crypto Abhicodes-crypto left review comments

Assignees

@JeevaRamu0104 JeevaRamu0104

Labels
A-core Area: Core flows C-feature Category: Feature request or enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@JeevaRamu0104 @jarnura @lsampras @SanchithHegde @Abhicodes-crypto @manojradhakrishnan