Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(router): added support for optional defend dispute api call and added evidence submission flow for checkout connector #979

Merged
merged 6 commits into from
May 3, 2023
Merged

feat(router): added support for optional defend dispute api call and added evidence submission flow for checkout connector #979

merged 6 commits into from
May 3, 2023

Conversation

sai-harsha-vardhan
Copy link
Contributor

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

  1. added support for optional defend dispute api call in evidence submission flow if connector requires it.
  2. added file upload and evidence submission flow for checkout connector.

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

There is a use case where we have to do 2 api calls for evidence submission (for connectors like checkout, adyen)

  1. Attach the evidence to dispute
  2. Defend the dispute
    Added support for optional second call to connector to defend the dispute

How did you test it?

Tested Manually
image

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@sai-harsha-vardhan sai-harsha-vardhan added A-connector-integration Area: Connector integration A-core Area: Core flows C-feature Category: Feature request or enhancement S-waiting-on-review Status: This PR has been implemented and needs to be reviewed M-api-contract-changes Metadata: This PR involves API contract changes labels Apr 25, 2023
@sai-harsha-vardhan sai-harsha-vardhan self-assigned this Apr 25, 2023
@sai-harsha-vardhan sai-harsha-vardhan requested review from a team as code owners April 25, 2023 10:38
Abhicodes-crypto
Abhicodes-crypto suggested changes Apr 25, 2023
View reviewed changes
Copy link
Contributor

@Abhicodes-crypto Abhicodes-crypto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor changes requested , other than that LGTM

@Abhicodes-crypto
Copy link
Contributor

Abhicodes-crypto commented Apr 25, 2023 •
edited
Loading

Is there a limit on the file size that is uploaded to hyperswitch ?

Narayanbhat166
Narayanbhat166 previously approved these changes Apr 28, 2023
View reviewed changes
@jarnura jarnura added S-ready-for-merge and removed S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels May 2, 2023
@jarnura jarnura added this pull request to the merge queue May 2, 2023
Merged via the queue into main with commit 4728d94 May 3, 2023
@SanchithHegde SanchithHegde deleted the add_support_for_defend_dispute branch May 3, 2023 06:37
@Narayanbhat166 Narayanbhat166 mentioned this pull request May 3, 2023
Closed
1 task
@bernard-eugine bernard-eugine added this to the May 2023 Release milestone May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Abhicodes-crypto Abhicodes-crypto Abhicodes-crypto approved these changes

@Narayanbhat166 Narayanbhat166 Narayanbhat166 approved these changes

@jarnura jarnura jarnura approved these changes

Assignees

@sai-harsha-vardhan sai-harsha-vardhan

Labels
A-connector-integration Area: Connector integration A-core Area: Core flows C-feature Category: Feature request or enhancement M-api-contract-changes Metadata: This PR involves API contract changes
Projects
No open projects
hyperswitch - Public Roadmap
Status: Merged
Milestone
May 2023 Release
Development

Successfully merging this pull request may close these issues.
6 participants
@sai-harsha-vardhan @Abhicodes-crypto @jarnura @Narayanbhat166 @SanchithHegde @bernard-eugine