fix(refund_list): updated refund list response status code when no refunds found. #974
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hrithikesh026
added
A-core
hrithikesh026
requested review from
a team,
jarnura and
ashokkjag
as code owners
Abhicodes-crypto
suggested changes
Apr 25, 2023
|
Abhicodes-crypto
approved these changes
Apr 25, 2023
Narayanbhat166
approved these changes
Apr 25, 2023
SanchithHegde
approved these changes
Apr 25, 2023
Narayanbhat166
added
S-ready-for-merge
and removed
S-waiting-on-review
jarnura
approved these changes
May 2, 2023
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
refund_list()function incrates/router/src/core/refunds.rssuch that it returns only Ok response with Vec of refunds.size: usizefield toRefundListResponseincrates/api_models/src/refunds.rsjust like inPaymentListResponse.Motivation and Context
"Get Refund List" would send an error response with status code 400 when no refunds are found.
Fixed it so it returns an empty list with status code 200 like "Get Payment List".
How did you test it?
Manual
Checklist
cargo +nightly fmt --allcargo clippy