Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(connector): [ACI] Add banking redirect support for EPS, Giropay, iDEAL, and Sofortueberweisung #890

Merged
merged 25 commits into from
May 2, 2023

Conversation

pixincreate
Copy link
Member

@pixincreate pixincreate commented Apr 15, 2023

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates

Description

  • This PR adds support for Banking Redirects for Connector ACI.
  • ACI's requirements are different for these banks and hence, before this gets merged, there is a need to make changes to the payments.rs file. This PR has temporary solution for all of those as banking redirects was developed keeping ACI in mind.
  • payments.rs needs to be modified to support bic, iban, and bank_name, billing_details, preferred_language needs to be optional.
  • Giropay, the transaction gets declined for unknown reasons. It is happening on their website itself.

Capture flow is unsupported

Additional Changes

  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables
  1. payments.rs, Changes to the enum BankRedirectData is needed in order to get ACI bank. redirects working.
  2. ACI result codes
  3. Transformers file
  4. Stripe Transformers

Motivation and Context

New feature for ACI that adds support for banking redirects.

How did you test it?

Testing was done manually since it requires human interaction for redirections

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@pixincreate pixincreate requested review from a team as code owners April 15, 2023 09:48
@pixincreate pixincreate self-assigned this Apr 15, 2023
@pixincreate pixincreate added A-connector-integration Area: Connector integration C-feature Category: Feature request or enhancement S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Apr 15, 2023
@pixincreate pixincreate changed the title Add banking redirect support for EPS, Giropay, iDEAL, and Sofortueberweisung feat(connector): ACI | Add banking redirect support for EPS, Giropay, iDEAL, and Sofortueberweisung Apr 15, 2023
@pixincreate pixincreate changed the title feat(connector): ACI | Add banking redirect support for EPS, Giropay, iDEAL, and Sofortueberweisung feat(connector): [ACI] Add banking redirect support for EPS, Giropay, iDEAL, and Sofortueberweisung Apr 15, 2023
@manojradhakrishnan manojradhakrishnan added this to the April'23 release milestone Apr 17, 2023
@manojradhakrishnan manojradhakrishnan linked an issue Apr 17, 2023 that may be closed by this pull request
jagan-jaya
jagan-jaya previously approved these changes Apr 17, 2023
@ArjunKarthik ArjunKarthik added S-waiting-on-author Status: This PR is incomplete or needs to address review comments and removed S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Apr 17, 2023
@pixincreate pixincreate added S-waiting-on-review Status: This PR has been implemented and needs to be reviewed and removed S-waiting-on-author Status: This PR is incomplete or needs to address review comments labels Apr 17, 2023
@ArjunKarthik
Copy link
Contributor

@pixincreate as discussed please remove your BankRedirectData changes. As per our api contract those can't be optional fields.

@ArjunKarthik ArjunKarthik added S-waiting-on-author Status: This PR is incomplete or needs to address review comments and removed S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Apr 18, 2023
@pixincreate pixincreate removed the S-waiting-on-author Status: This PR is incomplete or needs to address review comments label Apr 19, 2023
@ArjunKarthik ArjunKarthik added S-waiting-on-author Status: This PR is incomplete or needs to address review comments and removed S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Apr 24, 2023
ArjunKarthik
ArjunKarthik previously approved these changes Apr 24, 2023
@ArjunKarthik ArjunKarthik added S-waiting-on-review Status: This PR has been implemented and needs to be reviewed and removed S-waiting-on-author Status: This PR is incomplete or needs to address review comments labels Apr 24, 2023
@ArjunKarthik ArjunKarthik added R-waiting-on-L2 Review: Waiting on L2 reviewer R-L1-completed Review: L1 Review completed and removed S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels May 1, 2023
@jarnura jarnura added S-ready-for-merge and removed R-waiting-on-L2 Review: Waiting on L2 reviewer labels May 2, 2023
@jarnura jarnura added this pull request to the merge queue May 2, 2023
Merged via the queue into main with commit c86f2c0 May 2, 2023
@SanchithHegde SanchithHegde deleted the aci_bank_redirects branch May 2, 2023 20:59
@SanchithHegde SanchithHegde removed R-L1-completed Review: L1 Review completed S-ready-for-merge labels May 2, 2023
@SanchithHegde SanchithHegde removed a link to an issue May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-connector-integration Area: Connector integration C-feature Category: Feature request or enhancement
Projects
No open projects
Status: Merged
Development

Successfully merging this pull request may close these issues.

6 participants