-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(connector): [ACI] Add banking redirect support for EPS, Giropay, iDEAL, and Sofortueberweisung #890
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pixincreate
added
A-connector-integration
Area: Connector integration
C-feature
Category: Feature request or enhancement
S-waiting-on-review
Status: This PR has been implemented and needs to be reviewed
labels
Apr 15, 2023
pixincreate
changed the title
Add banking redirect support for EPS, Giropay, iDEAL, and Sofortueberweisung
feat(connector): ACI | Add banking redirect support for EPS, Giropay, iDEAL, and Sofortueberweisung
Apr 15, 2023
pixincreate
changed the title
feat(connector): ACI | Add banking redirect support for EPS, Giropay, iDEAL, and Sofortueberweisung
feat(connector): [ACI] Add banking redirect support for EPS, Giropay, iDEAL, and Sofortueberweisung
Apr 15, 2023
Closed
Closed
jagan-jaya
previously approved these changes
Apr 17, 2023
ArjunKarthik
requested changes
Apr 17, 2023
ArjunKarthik
added
S-waiting-on-author
Status: This PR is incomplete or needs to address review comments
and removed
S-waiting-on-review
Status: This PR has been implemented and needs to be reviewed
labels
Apr 17, 2023
pixincreate
added
S-waiting-on-review
Status: This PR has been implemented and needs to be reviewed
and removed
S-waiting-on-author
Status: This PR is incomplete or needs to address review comments
labels
Apr 17, 2023
pixincreate
force-pushed
the
aci_bank_redirects
branch
from
April 17, 2023 11:59
09e3e36
to
67d9c95
Compare
@pixincreate as discussed please remove your BankRedirectData changes. As per our api contract those can't be optional fields. |
ArjunKarthik
added
S-waiting-on-author
Status: This PR is incomplete or needs to address review comments
and removed
S-waiting-on-review
Status: This PR has been implemented and needs to be reviewed
labels
Apr 18, 2023
pixincreate
force-pushed
the
aci_bank_redirects
branch
from
April 19, 2023 09:49
56fad31
to
6c4bcbf
Compare
pixincreate
removed
the
S-waiting-on-author
Status: This PR is incomplete or needs to address review comments
label
Apr 19, 2023
ArjunKarthik
added
S-waiting-on-author
Status: This PR is incomplete or needs to address review comments
and removed
S-waiting-on-review
Status: This PR has been implemented and needs to be reviewed
labels
Apr 24, 2023
ArjunKarthik
previously approved these changes
Apr 24, 2023
ArjunKarthik
added
S-waiting-on-review
Status: This PR has been implemented and needs to be reviewed
and removed
S-waiting-on-author
Status: This PR is incomplete or needs to address review comments
labels
Apr 24, 2023
ArjunKarthik
approved these changes
Apr 25, 2023
jagan-jaya
approved these changes
Apr 26, 2023
ArjunKarthik
added
R-waiting-on-L2
Review: Waiting on L2 reviewer
R-L1-completed
Review: L1 Review completed
and removed
S-waiting-on-review
Status: This PR has been implemented and needs to be reviewed
labels
May 1, 2023
jarnura
approved these changes
May 2, 2023
jarnura
added
S-ready-for-merge
and removed
R-waiting-on-L2
Review: Waiting on L2 reviewer
labels
May 2, 2023
SanchithHegde
removed
R-L1-completed
Review: L1 Review completed
S-ready-for-merge
labels
May 2, 2023
Closed
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-connector-integration
Area: Connector integration
C-feature
Category: Feature request or enhancement
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
payments.rs
file. This PR has temporary solution for all of those as banking redirects was developed keeping ACI in mind.payments.rs
needs to be modified to supportbic
,iban
, andbank_name
,billing_details
,preferred_language
needs to be optional.Capture flow is unsupported
Additional Changes
enum BankRedirectData
is needed in order to get ACI bank. redirects working.Motivation and Context
New feature for ACI that adds support for banking redirects.
How did you test it?
Testing was done manually since it requires human interaction for redirections
Checklist
cargo +nightly fmt --all
cargo clippy