feat: PG Agnostic mandate using network_txns_id (Adyen, Authorizedotnet, Stripe) #855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manoj-juspay
added
A-connector-integration
manoj-juspay
changed the title
jarnura
requested changes
Apr 17, 2023
| @@ -298,14 +298,20 @@ pub enum MandateTxnType { | |||
| #[derive(Default, Eq, PartialEq, Debug, serde::Deserialize, serde::Serialize, Clone)] | |||
| pub struct MandateIds { | |||
| pub mandate_id: String, | |||
| pub connector_mandate_id: Option<String>, | |||
| pub mandate_reference_id: Option<MandateReferenceId>, | |||
crates/router/src/core/mandate.rs
Outdated
| ) { | ||
| let connector = new_mandate_data.connector.clone(); | ||
| logger::debug!("{:?}", new_mandate_data); | ||
| resp.request | ||
| .set_mandate_id(api_models::payments::MandateIds { | ||
| mandate_id: new_mandate_data.mandate_id.clone(), | ||
| connector_mandate_id: new_mandate_data.connector_mandate_id.clone(), | ||
| mandate_reference_id: None, //This is not used further in case needed please handle |
There was a problem hiding this comment.
just pass the value based on match logic
| api::PaymentMethodData::Card(ref ccard) => { | ||
| let payment_details = PaymentDetails::CreditCard(CreditCardDetails { | ||
| card_number: ccard.card_number.clone(), | ||
| // expiration_date: format!("{expiry_year}-{expiry_month}").into(), |
There was a problem hiding this comment.
sure, it was there before maybe for some reference
| @@ -4,7 +4,7 @@ use reqwest::Url; | |||
| use serde::{Deserialize, Serialize}; | |||
|
|
|||
| use crate::{ | |||
| connector::utils::PaymentsAuthorizeRequestData, | |||
| connector::utils::{missing_field_err, PaymentsAuthorizeRequestData}, | |||
There was a problem hiding this comment.
Remove missing_field_err in imports and use like utils::missing_field_err
| expiry_month: card.card_exp_month.clone(), | ||
| expiry_year: card.card_exp_year.clone(), | ||
| cvc: None, | ||
| brand: Some(CardBrand::Visa), //Fixme |
There was a problem hiding this comment.
Explain the problem for FIXME. If there is a issue already linked add the issue here.
| expiry_month: card.card_exp_month.clone(), | ||
| expiry_year: card.card_exp_year.clone(), | ||
| cvc: None, | ||
| brand: Some(CardBrand::Visa), //Fixme |
There was a problem hiding this comment.
And we can't go with Hard coding the CardBrand.
There was a problem hiding this comment.
@manoj-juspay there is a method get_card_issuer in connector/utils check if that can solve this issue. if not add one in the existing utils to work for your case
jarnura
added
the
S-waiting-on-author
jagan-jaya
requested changes
Apr 18, 2023
| @@ -246,6 +266,16 @@ pub struct AdyenCard { | |||
| expiry_month: Secret<String>, | |||
| expiry_year: Secret<String>, | |||
| cvc: Option<Secret<String>>, | |||
| brand: Option<CardBrand>, //Mandatory for mandate using network_txns_id | |||
| network_payment_reference: Option<String>, // | |||
Comment on lines
493
to
496
| let customer_id = item | ||
| .customer_id | ||
| .to_owned() | ||
| .ok_or_else(missing_field_err("customer_id"))?; |
There was a problem hiding this comment.
move this to src/connector/utils.rs RouterData trait add a method get_customer_id which will throw error if it is not present
| expiry_month: card.card_exp_month.clone(), | ||
| expiry_year: card.card_exp_year.clone(), | ||
| cvc: None, | ||
| brand: Some(CardBrand::Visa), //Fixme |
There was a problem hiding this comment.
@manoj-juspay there is a method get_card_issuer in connector/utils check if that can solve this issue. if not add one in the existing utils to work for your case
jarnura
added
S-needs-conflict-resolution
jagan-jaya
previously approved these changes
Apr 26, 2023
jarnura
requested changes
May 2, 2023
| .connector_customer | ||
| .connector_list | ||
| .contains(&connector.connector_name); | ||
| if connector_customer_filter { |
There was a problem hiding this comment.
Add comments for None and else cases.
manoj-juspay
added
the
M-database-changes
manoj-juspay
added
S-waiting-on-review
jarnura
previously approved these changes
May 2, 2023
jarnura
added
S-ready-for-merge
and removed
S-waiting-on-review
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
jarnura
previously approved these changes
May 3, 2023
jagan-jaya
approved these changes
May 3, 2023
jarnura
approved these changes
May 3, 2023
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Implemented Adyen mandate using connector_mandate_id
https://juspay.atlassian.net/browse/HYP-37
Additional Changes
Motivation and Context
How did you test it?
Setup mandate followed by recurring payment
Checklist
cargo +nightly fmt --allcargo clippy