ci(cypress): Added Config Testcases #6622
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with Changed Files |
pixincreate
reviewed
Nov 21, 2024
Comment on lines
+86
to
+99
| ]; | ||
| let req_data = data["Request"]; | ||
| let res_data = data["Response"]; | ||
| cy.citForMandatesCallTest( | ||
| fixtures.citConfirmBody, | ||
| req_data, | ||
| res_data, | ||
| 0, | ||
| true, | ||
| "automatic", | ||
| "setup_mandate", | ||
| globalState | ||
| ); | ||
| if (should_continue) |
There was a problem hiding this comment.
Suggested change
| ]; | |
| let req_data = data["Request"]; | |
| let res_data = data["Response"]; | |
| cy.citForMandatesCallTest( | |
| fixtures.citConfirmBody, | |
| req_data, | |
| res_data, | |
| 0, | |
| true, | |
| "automatic", | |
| "setup_mandate", | |
| globalState | |
| ); | |
| if (should_continue) | |
| ]; | |
| let req_data = data["Request"]; | |
| let res_data = data["Response"]; | |
| cy.citForMandatesCallTest( | |
| fixtures.citConfirmBody, | |
| req_data, | |
| res_data, | |
| 0, | |
| true, | |
| "automatic", | |
| "setup_mandate", | |
| globalState | |
| ); | |
| if (should_continue) |
Comment on lines
+107
to
+109
| false, //collect_shipping_address_from_wallet_connector | ||
| false, //always_collect_billing_address_from_wallet_connector | ||
| false, //always_collect_shipping_address_from_wallet_connector |
There was a problem hiding this comment.
Suggested change
| false, //collect_shipping_address_from_wallet_connector | |
| false, //always_collect_billing_address_from_wallet_connector | |
| false, //always_collect_shipping_address_from_wallet_connector | |
| false, // collect_shipping_address_from_wallet_connector | |
| false, // always_collect_billing_address_from_wallet_connector | |
| false, // always_collect_shipping_address_from_wallet_connector |
Comment on lines
+169
to
+171
| false, //collect_shipping_address_from_wallet_connector | ||
| false, //always_collect_billing_address_from_wallet_connector | ||
| false, //always_collect_shipping_address_from_wallet_connector |
There was a problem hiding this comment.
Suggested change
| false, //collect_shipping_address_from_wallet_connector | |
| false, //always_collect_billing_address_from_wallet_connector | |
| false, //always_collect_shipping_address_from_wallet_connector | |
| false, // collect_shipping_address_from_wallet_connector | |
| false, // always_collect_billing_address_from_wallet_connector | |
| false, // always_collect_shipping_address_from_wallet_connector |
Comment on lines
+233
to
+235
| false, //collect_shipping_address_from_wallet_connector | ||
| false, //always_collect_billing_address_from_wallet_connector | ||
| false, //always_collect_shipping_address_from_wallet_connector |
There was a problem hiding this comment.
Suggested change
| false, //collect_shipping_address_from_wallet_connector | |
| false, //always_collect_billing_address_from_wallet_connector | |
| false, //always_collect_shipping_address_from_wallet_connector | |
| false, // collect_shipping_address_from_wallet_connector | |
| false, // always_collect_billing_address_from_wallet_connector | |
| false, // always_collect_shipping_address_from_wallet_connector |
Comment on lines
+4
to
+6
| import getConnectorDetails, * as utils from "../PaymentUtils/Utils"; | ||
| let globalState; | ||
| describe("Config Tests", () => { |
There was a problem hiding this comment.
Suggested change
| import getConnectorDetails, * as utils from "../PaymentUtils/Utils"; | |
| let globalState; | |
| describe("Config Tests", () => { | |
| import getConnectorDetails, * as utils from "../PaymentUtils/Utils"; | |
| let globalState; | |
| describe("Config Tests", () => { |
Comment on lines
+286
to
+288
| false, //collect_shipping_address_from_wallet_connector | ||
| true, //always_collect_billing_address_from_wallet_connector | ||
| false, //always_collect_shipping_address_from_wallet_connector |
There was a problem hiding this comment.
Suggested change
| false, //collect_shipping_address_from_wallet_connector | |
| true, //always_collect_billing_address_from_wallet_connector | |
| false, //always_collect_shipping_address_from_wallet_connector | |
| false, // collect_shipping_address_from_wallet_connector | |
| true, // always_collect_billing_address_from_wallet_connector | |
| false, // always_collect_shipping_address_from_wallet_connector |
Comment on lines
+296
to
+307
| ]["PaymentIntentOffSession"]; | ||
| let req_data = data["Request"]; | ||
| let res_data = data["Response"]; | ||
| cy.createPaymentIntentTest( | ||
| fixtures.createPaymentBody, | ||
| req_data, | ||
| res_data, | ||
| "no_three_ds", | ||
| "automatic", | ||
| globalState | ||
| ); | ||
| if (should_continue) |
There was a problem hiding this comment.
Suggested change
| ]["PaymentIntentOffSession"]; | |
| let req_data = data["Request"]; | |
| let res_data = data["Response"]; | |
| cy.createPaymentIntentTest( | |
| fixtures.createPaymentBody, | |
| req_data, | |
| res_data, | |
| "no_three_ds", | |
| "automatic", | |
| globalState | |
| ); | |
| if (should_continue) | |
| ]["PaymentIntentOffSession"]; | |
| let req_data = data["Request"]; | |
| let res_data = data["Response"]; | |
| cy.createPaymentIntentTest( | |
| fixtures.createPaymentBody, | |
| req_data, | |
| res_data, | |
| "no_three_ds", | |
| "automatic", | |
| globalState | |
| ); | |
| if (should_continue) |
Comment on lines
+353
to
+356
| false, //collect_shipping_address_from_wallet_connector | ||
| false, //always_collect_billing_address_from_wallet_connector | ||
| false, //always_collect_shipping_address_from_wallet_connector | ||
| globalState |
There was a problem hiding this comment.
Suggested change
| false, //collect_shipping_address_from_wallet_connector | |
| false, //always_collect_billing_address_from_wallet_connector | |
| false, //always_collect_shipping_address_from_wallet_connector | |
| globalState | |
| false, // collect_shipping_address_from_wallet_connector | |
| false, // always_collect_billing_address_from_wallet_connector | |
| false, // always_collect_shipping_address_from_wallet_connector | |
| globalState |
Comment on lines
+363
to
+377
| ]["PaymentIntentOffSession"]; | ||
| let req_data = data["Request"]; | ||
| let res_data = data["Response"]; | ||
| cy.createPaymentIntentTest( | ||
| fixtures.createPaymentBody, | ||
| req_data, | ||
| res_data, | ||
| "no_three_ds", | ||
| "automatic", | ||
| globalState | ||
| ); | ||
| if (should_continue) | ||
| should_continue = utils.should_continue_further(res_data); | ||
| }); | ||
| it("payment_methods-call-test", () => { |
There was a problem hiding this comment.
Suggested change
| ]["PaymentIntentOffSession"]; | |
| let req_data = data["Request"]; | |
| let res_data = data["Response"]; | |
| cy.createPaymentIntentTest( | |
| fixtures.createPaymentBody, | |
| req_data, | |
| res_data, | |
| "no_three_ds", | |
| "automatic", | |
| globalState | |
| ); | |
| if (should_continue) | |
| should_continue = utils.should_continue_further(res_data); | |
| }); | |
| it("payment_methods-call-test", () => { | |
| ]["PaymentIntentOffSession"]; | |
| let req_data = data["Request"]; | |
| let res_data = data["Response"]; | |
| cy.createPaymentIntentTest( | |
| fixtures.createPaymentBody, | |
| req_data, | |
| res_data, | |
| "no_three_ds", | |
| "automatic", | |
| globalState | |
| ); | |
| if (should_continue) | |
| should_continue = utils.should_continue_further(res_data); | |
| }); | |
| it("payment_methods-call-test", () => { |
There was a problem hiding this comment.
can we move all this into a single file? preferably business-profile.json and keep them all as objects like we've done in v2? that way you will not have the need to keep multiple files for one area viz., business-profile.
at present, we've 2 files namely,
- `create-business-profile.json
update-business-profile.json
and both of these have at max 3 lines.
we can merge them into one and call them via objects in .cy.js files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Added below config related testcases in cypress
"collect_shipping_details_from_wallet_connector"
"collect_billing_details_from_wallet_connector"
"always_collect_billing_details_from_wallet_connector"
"always_collect_shipping_details_from_wallet_connector"
Additional Changes
Motivation and Context
To validate the config changes in automation
How did you test it?
Ran locally
Checklist
cargo +nightly fmt --allcargo clippy