ci(cypress): Add Noon Connector #6603
Conversation
likhinbopanna
added
A-CI-CD
|
Review changes with Changed Files
|
| last4: "4242", | ||
| card_type: "CREDIT", | ||
| card_network: "Visa", | ||
| card_issuer: "STRIPE PAYMENTS UK LIMITED", |
There was a problem hiding this comment.
This is just card_issuer nothing related to connector
| }, | ||
| connector_metadata: connectorMetadata, | ||
| customer_acceptance: null, | ||
| currency: "AED", |
There was a problem hiding this comment.
Please do not pass currency in confirm calls.
I do not think we need it in refunds either.
There was a problem hiding this comment.
We need to pass currency in some of the scenarios where we use create + confirm
There was a problem hiding this comment.
Create + confirm, okay. But in every other case.
There was a problem hiding this comment.
Even Refund Payments use create + confirm
| }, | ||
| Response: { | ||
| status: 200, | ||
| trigger_skip: true, |
There was a problem hiding this comment.
I would suggest you moving this to new object called as Configs.
Please check my draft PR for reference.
There was a problem hiding this comment.
We can make this change when your pr gets merged
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
…ed-cypress * 'main' of github.com:juspay/hyperswitch: fix(connector): [Cybersource] change commerce indicator for applepay (#6634) ci(cypress): Add Noon Connector (#6603) fix(analytics): remove first_attempt group by in Payment Intent old metrics (#6627) chore(version): 2024.11.22.0 refactor: update API response for JSON deserialization errors (#6610) fix(connector): [Novalnet] Get email from customer email if billing.email is not present (#6619) feat(connector): [AIRWALLEX] Update production endpoint (#6632) feat(themes): Add `theme_name` and `entity_type` in themes table (#6621) feat(connector): [Xendit] Template PR (#6593)
SanchithHegde
removed
the
S-waiting-on-review
Type of Change
Description
Add Noon Connector for Cypress Automation
Note : Noon supports only 3ds payments , so all the no_three_ds payments are skipped
Additional Changes
Motivation and Context
Noon connector was not available in the cypress automation
How did you test it?
Checklist
cargo +nightly fmt --allcargo clippy