refactor(routing): Refactor api v2 routes for deactivating and retrieving the routing config #5478

Aprabhat19 · 2024-07-30T11:24:12Z

Type of Change

Description

Refactor api v2 routes for deactivating and retrieving the routing config

Additional Changes

This PR modifies the API contract
This PR modifies the database schema
This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

To deactivate the routing config

curl --location --request PATCH 'http://localhost:8080/v2/profiles/pro_VirB3AxB3qItFTnLsuA2/deactivate_routing_algorithm' \
--header 'Content-Type: application/json' \
--header 'api-key: dev_CMjrHy1A62kEwdzCDoLWRBta6xBZalgupmamFfdKfJdMjklfCil5S1wqAZ0F4Jw5' \
--data '
'

To retrieve the routing config

curl --location 'http://localhost:8080/v2/routing_algorithm/routing_merchant_1722847196_EiushCG51H' \
--header 'api-key: dev_CMjrHy1A62kEwdzCDoLWRBta6xBZalgupmamFfdKfJdMjklfCil5S1wqAZ0F4Jw5'

Checklist

I formatted the code cargo +nightly fmt --all
I addressed lints thrown by cargo clippy
I reviewed the submitted code
I added unit tests for my changes where possible

…-v2-routing

…into api-v2-routing

…-v2-routing

…into api-v2-routing

This reverts commit ea3a91f.

The base branch was changed.

…-v2-routes

…into api-v2-routes

jarnura · 2024-08-05T06:20:29Z

crates/router/src/core/routing.rs

-        .change_context(errors::ApiErrorResponse::MissingRequiredField {
-            field_name: "algorithm",
-        })
-        .attach_printable("Algorithm of config not given")?;

    let business_profile = core_utils::validate_and_get_business_profile(


we can have a separate function without the Option, just taking the value. Take this changes in next pull requests

jarnura · 2024-08-05T06:21:09Z

crates/router/src/core/routing.rs

+        RoutingAlgorithmUpdate::fetch_routing_algo(merchant_account.get_id(), &algorithm_id.0, db)
+            .await?;
+    // TODO: Move to domain types of Business Profile
+    core_utils::validate_and_get_business_profile(


we can have a separate function without the Option, just taking the value. Take this changes in next pull requests

* 'main' of github.com:juspay/hyperswitch: (37 commits) fix(connector): Fixed status mapping for Plaid (#5525) feat(core): accept profile_id in merchant_account, connectors and customers core functions (#5505) refactor(auth): Pass `profile_id` from the auth to core functions (#5520) refactor(routing): Refactor api v2 routes for deactivating and retrieving the routing config (#5478) refactor(cypress): pass `connector_type` externally (#5522) refactor(router): refactor merchant_connector update v2 flow (#5484) feat(router): add accept language header middleware (#5500) chore(version): 2024.08.05.0 chore(postman): update Postman collection files fix(pm_auth): Added mca status check in pml (#5421) refactor(payment_methods): List the Payment Methods for Merchant , based on the connector type (#4909) fix(router): [Iatapay] make error status and error message optional (#5382) chore(version): 2024.08.02.0 feat(business_profile): introduce domain models for business profile v1 and v2 APIs (#5497) feat(auth): Add `profile_id` in `AuthenticationData` (#5492) feat(core): accept business profile in core functions for payments, refund, payout and disputes (#5498) refactor(router): domain and diesel model changes for merchant_connector_account create v2 flow (#5462) fix(open_payment_links): send displaySavedPaymentMethods as false explicitly for open payment links (#5501) refactor(role): determine level of role entity (#5488) feat(cypress): add corner cases (#5481) ...

Aprabhat19 and others added 30 commits July 22, 2024 13:15

refactor create api

862edf1

refactor link and unlink apis

519cbf2

resolve conflicts

27e1e00

refactor till link routing algorithm

07c4c0b

remove unnecessary fields

498fb42

remove unused code

8a50133

Merge branch 'main' of https://github.com/juspay/hyperswitch into api…

45b7847

…-v2-routing

fix(chore): just fmt

ce5369e

chore: run formatter

04d8201

refactor create and activate apis for routing

251f8ae

resolved conflicts

e3ecdd8

resolved conflicts

2e58868

chore: run formatter

5d283da

fix clippy

32eedc3

Merge branch 'api-v2-routing' of https://github.com/juspay/hyperswitch …

d49a626

…into api-v2-routing

chore: run formatter

d38949f

Merge branch 'main' of https://github.com/juspay/hyperswitch into api…

5c2cf33

…-v2-routing

minor refactor

30c06d0

Merge branch 'api-v2-routing' of https://github.com/juspay/hyperswitch …

fe5f8fc

…into api-v2-routing

fix spell check

82f6f09

address failing checks

a995a03

address errors

d4526fc

chore: run formatter

1b3be41

make changes to the path

bb3dfff

Merge branch 'api-v2-routing' of https://github.com/juspay/hyperswitch …

ca9e63e

…into api-v2-routing

address comments

2eb0be4

chore: run formatter

1266fbb

make api changes

be54ced

Merge branch 'api-v2-routing' of https://github.com/juspay/hyperswitch …

a8da033

…into api-v2-routing

implement v2 for retrieving and deactivating the routing algorithm

e810065

Aprabhat19 and others added 2 commits August 1, 2024 15:18

Revert "address clippy errors"

9e7b200

This reverts commit ea3a91f.

ci: use regex to exclude v2 features from feature list

518054b

Base automatically changed from api-v2-routing to main August 1, 2024 09:53

Aprabhat19 requested a review from a team as a code owner August 1, 2024 09:53

Aprabhat19 and others added 7 commits August 1, 2024 15:58

resolved conflicts

a6f0f26

resolved conflicts

9d7afee

chore: run formatter

5a013b7

Merge branch 'main' of https://github.com/juspay/hyperswitch into api…

7e7af78

…-v2-routes

remove unnecessary line of code

c65fdc0

Merge branch 'api-v2-routes' of https://github.com/juspay/hyperswitch …

fdce57d

…into api-v2-routes

adddress errors

b11c867

Aprabhat19 requested review from jarnura and removed request for a team August 5, 2024 05:48

Merge branch 'main' into api-v2-routes

05abd75

jarnura previously approved these changes Aug 5, 2024

View reviewed changes

Narayanbhat166 previously approved these changes Aug 5, 2024

View reviewed changes

Aprabhat19 linked an issue Aug 5, 2024 that may be closed by this pull request

[REFACTOR] Refactor deactivating and retrieve apis for routing v2 #5521

Closed

2 tasks

change the http method for deactivate

76d322b

Aprabhat19 dismissed stale reviews from Narayanbhat166 and jarnura via 76d322b August 5, 2024 08:45

prajjwalkumar17 approved these changes Aug 5, 2024

View reviewed changes

Narayanbhat166 approved these changes Aug 5, 2024

View reviewed changes

jarnura approved these changes Aug 5, 2024

View reviewed changes

pixincreate added this pull request to the merge queue Aug 5, 2024

Merged via the queue into main with commit 3fea00c Aug 5, 2024
17 of 18 checks passed

pixincreate deleted the api-v2-routes branch August 5, 2024 10:21

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor(routing): Refactor api v2 routes for deactivating and retrieving the routing config #5478

refactor(routing): Refactor api v2 routes for deactivating and retrieving the routing config #5478

Aprabhat19 commented Jul 30, 2024 •

edited

Loading

jarnura Aug 5, 2024

jarnura Aug 5, 2024

refactor(routing): Refactor api v2 routes for deactivating and retrieving the routing config #5478

refactor(routing): Refactor api v2 routes for deactivating and retrieving the routing config #5478

Conversation

Aprabhat19 commented Jul 30, 2024 • edited Loading

Type of Change

Description

Additional Changes

Motivation and Context

How did you test it?

Checklist

jarnura Aug 5, 2024

Choose a reason for hiding this comment

jarnura Aug 5, 2024

Choose a reason for hiding this comment

Aprabhat19 commented Jul 30, 2024 •

edited

Loading