feat(globalsearch): Implement tag-based filters in global search #5151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lsampras
reviewed
Jun 28, 2024
| .add_filter_clause("payment_method.keyword".to_string(), payment_method) | ||
| .switch()?; | ||
| }; | ||
| if let Some(customer_email) = filters.customer_email { |
There was a problem hiding this comment.
Suggested change
| if let Some(customer_email) = filters.customer_email { | |
| if let Some(customer_email) = filters.customer_email && !customer_email.is_empty() { |
can we add this sort of validation to make sure that empty arrays are ignored?
There was a problem hiding this comment.
Yes, added the validations to ignore empty arrays
ivor11
reviewed
Jun 28, 2024
lsampras
approved these changes
Jul 1, 2024
Abhitator216
approved these changes
Jul 1, 2024
pixincreate
added a commit
that referenced
this pull request
Jul 2, 2024
…ror-handling-in-cypress * 'main' of github.com:juspay/hyperswitch: fix(auth_methods): Add checks for duplicate `auth_method` in create API (#5161) chore(version): 2024.07.02.0 fix(router): rename the browser name header to `x-browser-name` (#5162) fix(router): mark retry payment as failure if `connector_tokenization` fails (#5114) fix(connector): [Paypal] dispute webhook deserialization failure (#5111) feat(analytics): Add v2 payment analytics (payment-intents analytics) (#5150) feat(globalsearch): Implement tag-based filters in global search (#5151) refactor(connector): Add amount conversion framework to iatapay along with amount conversion code to connector template (#4866) feat(payment_link): add multiple custom css support in business level (#5137) feat(connector): [Bambora Apac] Template for integration (#5062) feat(tls): add support for https in actix web (#5089) chore(ci): fix ci tests failing by removing them (#5167) chore(version): 2024.07.01.0 chore(postman): update Postman collection files ci(postman): log request id for user tests (#5159) chore(euclid_wasm): make field domain optional wasm (#5154)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Added more explicit filters to global search:
Currently we rely on free form text search where opensearch matches the keywords across the entire document
Filters added currently:
Can map multiple options for every filter for global search
Additional Changes
Motivation and Context
Adding a more refined & strict search query where we do exact matches on fields provides better results
How did you test it?
Tested using local data by sending cURL requests through Postman.
Checklist
cargo +nightly fmt --allcargo clippy