Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(connector): add amount conversion framework to payone #4981

Merged
merged 4 commits into from
Jul 25, 2024

Conversation

KiranKBR
Copy link
Contributor

@KiranKBR KiranKBR commented Jun 12, 2024

Type of Change

  • Refactoring

Description

This PR adds amount conversion framework to payone

Note: payone works in MinorUnit

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Flows to test in payone

-Payout

curl --location 'http://127.0.0.1:8080/payouts/create' \
--header 'Content-Type: application/json' \
--header 'api-key: dev_vwnvqSv9eOBQ0krvZ9g0um2HCsD3KgwJzJME1THgqgo0d8qNDHerOwVBrxEGRg6F' \
--data-raw '{
    "amount": 100,
    "currency": "EUR",
    "customer_id": "payout_customer",
    "email": "[email protected]",
    "name": "John Doe",
    "phone": "999999999",
    "phone_country_code": "+65",
    "description": "Its my first payout request",
    "payout_type": "card",
    "payout_method_data": {
        "card": {
            "card_number": "4301111100000200",
            "expiry_month": "05",
            "expiry_year": "30",
            "card_holder_name": "John Smith"
        }
    },
    "billing": {
        "address": {
            "line1": "1467",
            "line2": "Harrison Street",
            "line3": "Harrison Street",
            "city": "San Fransico",
            "state": "NY",
            "zip": "94122",
            "country": "US",
            "first_name": "John",
            "last_name": "Doe"
        },
        "phone": {
            "number": "8056594427",
            "country_code": "+91"
        }
    },
    "entity_type": "Individual",
    "recurring": false,
    "metadata": {
        "ref": "123"
    },
        "business_country": "US",
    "business_label": "default",
    
    
    
    
    "auto_fulfill": true,
    "confirm": true
}'

image## Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible

@KiranKBR KiranKBR requested review from a team as code owners June 12, 2024 19:36
@KiranKBR KiranKBR changed the title do-amount-conversion-for-payone refactor(connector): add amount conversion framework to payone Jun 13, 2024
@KiranKBR KiranKBR self-assigned this Jun 13, 2024
Base automatically changed from 5188-amount-conversion-do-amount-conversion-for-iatapay to main July 1, 2024 11:36
@KiranKBR KiranKBR requested review from a team as code owners July 1, 2024 11:36
@KiranKBR KiranKBR force-pushed the do-amount-conversion-for-payone branch 6 times, most recently from 7ec8183 to a94a70e Compare July 4, 2024 07:22
@KiranKBR KiranKBR force-pushed the do-amount-conversion-for-payone branch from 277a9ae to c12b662 Compare July 17, 2024 13:25
@KiranKBR KiranKBR force-pushed the do-amount-conversion-for-payone branch from 8d6ad50 to 0e76ae6 Compare July 22, 2024 12:12
@KiranKBR KiranKBR removed the request for review from a team July 24, 2024 16:37
@likhinbopanna likhinbopanna added this pull request to the merge queue Jul 25, 2024
Merged via the queue into main with commit 5eccffa Jul 25, 2024
13 checks passed
@likhinbopanna likhinbopanna deleted the do-amount-conversion-for-payone branch July 25, 2024 11:39
pixincreate added a commit that referenced this pull request Jul 30, 2024
* 'main' of github.com:juspay/hyperswitch:
  refactor(router): remove `connector_account_details` and `connector_webhook_details` in merchant_connector_account list response (#5457)
  feat: add env variable for enable key manager service (#5442)
  chore(version): 2024.07.29.0
  feat(payments): support sort criteria in payments list (#5389)
  refactor(connector):  add amount conversion framework to placetopay (#4988)
  feat(connector): [Bambora APAC] add mandate flow (#5376)
  ci: set code owners for payment methods files (#5453)
  refactor(opensearch): Add Error Handling for Empty Query and Filters in Request (#5432)
  chore: address Rust 1.80 clippy lints (#5447)
  feat(connector): [FISERV] Move connector to hyperswitch_connectors (#5441)
  ci: add support for just hack_v2 check for PRs (#5426)
  fix: added created at and modified at keys in PaymentAttemptResponse (#5412)
  refactor(merchant_account_v2): recreate id for `merchant_account` v2  (#5439)
  chore(version): 2024.07.26.0
  feat(events): forward the tenant configuration as part of the kafka message (#5224)
  refactor(connector):  add amount conversion framework to payone (#4981)
  refactor(user_roles): make org and merchant id nullable (#5353)
  fix(euclid): change the address taken in SessionFlowRouting from shipping to billing address (#5435)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants