refactor(connector): add amount framework to payme & Trustpay with googlePay, ApplePay for bluesnap, Noon & Trustpay #4833

sahkal · 2024-05-31T09:02:19Z

Type of Change

Refactoring

Description

This PR adds Amount conversion framework to Payme, along with ApplePay GooglePay flows for all connectors

Note:

Payme works in MinorUnit, so no conversion is involved

TrustPay, Bluesnap, Noon works in string Major Unit

ApplePay, GooglePay also works in string Major Unit

ApplePay

GooglePay

Additional Changes

This PR modifies the API contract
This PR modifies the database schema
This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Flows to test

Payme

Authorise
Refunds
ApplePay

TrustPay

Authorise
Refunds
Bank redirects( Ideal, giropay )
ApplePay & Google Pay

BlueSnap

ApplePay & GooglePay

Noon

ApplePay & GooglePay

Payments Authorise

curl --location 'http://localhost:8080/payments' \
--header 'Content-Type: application/json' \
--header 'Accept: application/json' \
--header 'api-key: dev_WFGYwzFgFxWy9YEwtZTVU2O25M7vO2TGspSXG72pR6Hb4ZHpN3AuGnw9AKloaG5K' \
--data-raw '{   
    "confirm":true,
    "currency":"USD",
      "billing": {
    "address": {
      "line1": "1467",
      "line2": "Harrison Street",
      "line3": "Harrison Street",
      "city": "San Fransico",
      "state": "California",
      "zip": "94122",
      "country": "IN",
      "first_name": "joseph",
      "last_name": "Doe"
    },
    "phone": {
      "number": "8056594427",
      "country_code": "+91"
    }
  },
    "order_details": [
        {
            "product_name": "Tea",
            "quantity": 1,
            "amount": 110,
            "product_img_link": "https://thumbs.dreamstime.com/b/indian-tea-spices-masala-chai-33827904.jpg"
        },
        {
            "product_name": "Tea",
            "quantity": 20,
            "amount": 110,
            "product_img_link": "https://thumbs.dreamstime.com/b/indian-tea-spices-masala-chai-33827904.jpg"
        },
        {
            "product_name": "Tea",
            "quantity": 1,
            "amount": 110,
            "product_img_link": "https://thumbs.dreamstime.com/b/indian-tea-spices-masala-chai-33827904.jpg"
        }
    ],
    "return_url":"https://google.com",
    "email":"[email protected]",
    "payment_method": "card",
    "payment_method_type": "credit",
    "payment_method_data": {
        "card": {
            "card_number": "4111111111111111",
            "card_exp_month": "10",
            "card_exp_year": "2027",
            "card_holder_name": "joseph Doe",
            "card_cvc": "2732"
        }
    },
    "amount":2345
}
'

Refund Flow

curl --location 'http://localhost:8080/refunds' \
--header 'Content-Type: application/json' \
--header 'Accept: application/json' \
--header 'api-key: dev_WFGYwzFgFxWy9YEwtZTVU2O25M7vO2TGspSXG72pR6Hb4ZHpN3AuGnw9AKloaG5K' \
--data '{
    "payment_id": "pay_bziDv82xazJ80qYwcMyI",
    "amount": 2345,
    "reason": "Customer returned product",
    "refund_type": "instant",
    "metadata": {
        "udf1": "value1",
        "new_customer": "true",
        "login_date": "2019-09-10T10:11:12Z"
    }
}'

Trustpay :

Authorise:

curl --location 'http://localhost:8080/payments' \
--header 'Content-Type: application/json' \
--header 'Accept: application/json' \
--header 'api-key: dev_nhddAVimdzryaUmPYHUx33YnboKvcW5b3AeiPJnbX7tXbIQ8lMlaNrQ4KZcpi5a4' \
--data-raw '{
    "amount": 6540,
    "currency": "USD",
    "confirm": true,
    "capture_method": "automatic",
    "capture_on": "2022-09-10T10:11:12Z",
    "amount_to_capture": 6540,
    "customer_id": "StripeCustomer",
    "email": "[email protected]",
    "name": "John Doe",
    "phone": "999999999",
    "phone_country_code": "+1",
    "description": "Its my first payment request",
    "authentication_type": "no_three_ds",
    "return_url": "https://duck.com",
    "payment_method": "card",
    "payment_method_type": "credit",
    "payment_method_data": {
        "card": {
            "card_number": "5200000000001005",
            "card_exp_month": "10",
            "card_exp_year": "25",
            "card_holder_name": "joseph Doe",
            "card_cvc": "123"
        }
    },
    "billing": {
        "address": {
            "line1": "1467",
            "line2": "Harrison Street",
            "line3": "Harrison Street",
            "city": "San Fransico",
            "state": "California",
            "zip": "94122",
            "country": "US",
            "first_name": "joseph",
            "last_name": "Doe"
        },
        "phone": {
            "number": "8056594427",
            "country_code": "+91"
        }
    },
    "shipping": {
        "address": {
            "line1": "1467",
            "line2": "Harrison Street",
            "line3": "Harrison Street",
            "city": "San Fransico",
            "state": "California",
            "zip": "94122",
            "country": "US",
            "first_name": "joseph",
            "last_name": "Doe"
        },
        "phone": {
            "number": "8056594427",
            "country_code": "+91"
        }
    },
    "browser_info": {
        "user_agent": "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/70.0.3538.110 Safari/537.36",
        "accept_header": "text/html,application/xhtml+xml,application/xml;q=0.9,image/webp,image/apng,*/*;q=0.8",
        "language": "nl-NL",
        "color_depth": 24,
        "screen_height": 723,
        "screen_width": 1536,
        "time_zone": 0,
        "java_enabled": true,
        "java_script_enabled": true,
        "ip_address": "125.0.0.1"
    },
    "statement_descriptor_name": "joseph",
    "statement_descriptor_suffix": "JS",
    "metadata": {
        "udf1": "value1",
        "new_customer": "true",
        "login_date": "2019-09-10T10:11:12Z"
    }
}
'

Refund:

curl --location 'http://localhost:8080/refunds' \
--header 'Content-Type: application/json' \
--header 'Accept: application/json' \
--header 'api-key: dev_nhddAVimdzryaUmPYHUx33YnboKvcW5b3AeiPJnbX7tXbIQ8lMlaNrQ4KZcpi5a4' \
--data '{
    "payment_id": "pay_Y2KCfAMdAe4Q45u8RDkH",
    "amount": 6540,
    "reason": "Customer returned product",
    "refund_type": "instant",
    "metadata": {
        "udf1": "value1",
        "new_customer": "true",
        "login_date": "2019-09-10T10:11:12Z"
    }
}'

TrustPay

ApplePay & GooglePay

GooglePay

curl --location 'http://localhost:8080/payments' \
--header 'Content-Type: application/json' \
--header 'Accept: application/json' \
--header 'api-key: dev_jHQnaO31f4y9Ride9rMBTaygae3MgRQ63BzzsJk8A43K7J4hd2oL6CP8Wf7B8gIr' \
--data-raw '{
    "amount": 1000,
    "currency": "EUR",
    "confirm": true,
    "capture_method": "automatic",
    "capture_on": "2022-09-10T10:11:12Z",
    "customer_id": "CustomerX",
    "email": "[email protected]",
    "name": "John Doe",
    "phone": "999999999",
    "phone_country_code": "+1",
    "description": "Its my first payment request",
    "authentication_type": "no_three_ds",
    "return_url": "https://google.com",
    "payment_method": "wallet",
    "payment_method_type": "google_pay",
    "payment_method_data": {
        "wallet": {
            "google_pay": {
                "type": "CARD",
                "description": "Visa •••• 1111",
                "info": {
                    "card_network": "VISA",
                    "card_details": "1111"
                },
                "tokenization_data": {
                    "type": "PAYMENT_GATEWAY",
                    "token": "{\"signature\":\"MEUCIQDq+hdZFXgAupCk3R5cr9wrDAP/jGPMJkqRsL9pBl8JMQIgA35XbERBWAxupnnSVlVc7yKqTiskRJHfQfWsy8dedLE\\u003d\",\"protocolVersion\":\"ECv1\",\"signedMessage\":\"{\\\"encryptedMessage\\\":\\\"sl3vpO1yFN8a1eYASko9fXRoFsRhGGLMvlewvZxmUhfND29xlG3j4PZAD9Kcov7jd0uP63LNhaZ8iYNkV/6Qwv0j6UfY1IST+HyndIOUQZlN5H6I8hbpvpP5nmjU3gbLnlkk8W5WUp6MAC76keYEW1rRF2qRgLqymYWEWicl9LkDVW6bz0bMuybsqljxaDIp5tGO4dQ9ajV2qwuw4AZx5MA3brKsKjmsJQbe5XIX48rt88yPZDcNQFKfoeo+DCgNpjATIlhIZNZxSue1oBi2can82Fa0+38nM446R8TUwN2pGgTJFqymvIKTZZEtutd8UW1+qCnlogRmyuAfK08QD7OuFFPcVUMiMsYjkS2baHEa9jczpjrBUPbm/DQnHbLkqarsuRqHJ86ZqxMPXMAAato6UsMgwgIeGHAgSWUj0x+e8oQCBm8TGbnIwxsGXlIutIfa9GooIUM1paz+\\\",\\\"ephemeralPublicKey\\\":\\\"BKxNuDGBs2YhCYpcZDWvw4nyo6w95pN2e+V3bfZm/cg8aN1wLHL1KkKceG7LrFkjOFbrO8RDQ3FQ+Yo+CMCtzk0\\\\u003d\\\",\\\"tag\\\":\\\"jbyoC/PCw4pJyK54vvZsL8eqzFOzUVd4hG4qCVHfKN4\\\\u003d\\\"}\"}"
                }
            }
        }
    },
    "billing": {
        "address": {
            "line1": "1467",
            "line2": "Harrison Street",
            "line3": "Harrison Street",
            "city": "San Fransico",
            "state": "Dubai",
            "zip": "94122",
            "country": "AE",
            "first_name": "joseph",
            "last_name": "Doe"
        },
        "phone": {
            "number": "8056594427",
            "country_code": "+97"
        }
    },
    "shipping": {
        "address": {
            "line1": "1467",
            "line2": "Harrison Street",
            "line3": "Harrison Street",
            "city": "San Fransico",
            "state": "California",
            "zip": "94122",
            "country": "AE",
            "first_name": "joseph",
            "last_name": "Doe"
        },
        "phone": {
            "number": "8056594427",
            "country_code": "+91"
        }
    },
    "metadata": {
        "count_tickets": 1,
        "transaction_number": "5590043"
    },
    "payment_type": "setup_mandate",
    "setup_future_usage": "off_session",
    "customer_acceptance": {
        "acceptance_type": "offline",
        "accepted_at": "1963-05-03T04:07:52.723Z",
        "online": {
            "ip_address": "13.232.74.226",
            "user_agent": "amet irure esse"
        }
    }
}
'

BlueSnap

ApplePay & GooglePay

Google

curl --location 'http://localhost:8080/payments' \
--header 'Content-Type: application/json' \
--header 'Accept: application/json' \
--header 'api-key: dev_m3D6IZzGh9dAGXeDn1RHCMooq6YWaRpYw65iefMCRoJrWOznbc1CZ0mLjXbARTkv' \
--data-raw '{
    "amount": 1000,
    "currency": "EUR",
    "confirm": true,
    "capture_method": "automatic",
    "capture_on": "2022-09-10T10:11:12Z",
    "customer_id": "CustomerX",
    "email": "[email protected]",
    "name": "John Doe",
    "phone": "999999999",
    "phone_country_code": "+1",
    "description": "Its my first payment request",
    "authentication_type": "no_three_ds",
    "return_url": "https://google.com",
    "payment_method": "wallet",
    "payment_method_type": "google_pay",
    "payment_method_data": {
        "wallet": {
            "google_pay": {
                "type": "CARD",
                "description": "Visa •••• 1111",
                "info": {
                    "card_network": "VISA",
                    "card_details": "1111"
                },
                "tokenization_data": {
                    "type": "PAYMENT_GATEWAY",
                    "token": "{\"signature\":\"MEUCIQDq+hdZFXgAupCk3R5cr9wrDAP/jGPMJkqRsL9pBl8JMQIgA35XbERBWAxupnnSVlVc7yKqTiskRJHfQfWsy8dedLE\\u003d\",\"protocolVersion\":\"ECv1\",\"signedMessage\":\"{\\\"encryptedMessage\\\":\\\"sl3vpO1yFN8a1eYASko9fXRoFsRhGGLMvlewvZxmUhfND29xlG3j4PZAD9Kcov7jd0uP63LNhaZ8iYNkV/6Qwv0j6UfY1IST+HyndIOUQZlN5H6I8hbpvpP5nmjU3gbLnlkk8W5WUp6MAC76keYEW1rRF2qRgLqymYWEWicl9LkDVW6bz0bMuybsqljxaDIp5tGO4dQ9ajV2qwuw4AZx5MA3brKsKjmsJQbe5XIX48rt88yPZDcNQFKfoeo+DCgNpjATIlhIZNZxSue1oBi2can82Fa0+38nM446R8TUwN2pGgTJFqymvIKTZZEtutd8UW1+qCnlogRmyuAfK08QD7OuFFPcVUMiMsYjkS2baHEa9jczpjrBUPbm/DQnHbLkqarsuRqHJ86ZqxMPXMAAato6UsMgwgIeGHAgSWUj0x+e8oQCBm8TGbnIwxsGXlIutIfa9GooIUM1paz+\\\",\\\"ephemeralPublicKey\\\":\\\"BKxNuDGBs2YhCYpcZDWvw4nyo6w95pN2e+V3bfZm/cg8aN1wLHL1KkKceG7LrFkjOFbrO8RDQ3FQ+Yo+CMCtzk0\\\\u003d\\\",\\\"tag\\\":\\\"jbyoC/PCw4pJyK54vvZsL8eqzFOzUVd4hG4qCVHfKN4\\\\u003d\\\"}\"}"
                }
            }
        }
    },
    "billing": {
        "address": {
            "line1": "1467",
            "line2": "Harrison Street",
            "line3": "Harrison Street",
            "city": "San Fransico",
            "state": "Dubai",
            "zip": "94122",
            "country": "AE",
            "first_name": "joseph",
            "last_name": "Doe"
        },
        "phone": {
            "number": "8056594427",
            "country_code": "+97"
        }
    },
    "shipping": {
        "address": {
            "line1": "1467",
            "line2": "Harrison Street",
            "line3": "Harrison Street",
            "city": "San Fransico",
            "state": "California",
            "zip": "94122",
            "country": "AE",
            "first_name": "joseph",
            "last_name": "Doe"
        },
        "phone": {
            "number": "8056594427",
            "country_code": "+91"
        }
    },
    "metadata": {
        "count_tickets": 1,
        "transaction_number": "5590043"
    },
    "customer_acceptance": {
        "acceptance_type": "offline",
        "accepted_at": "1963-05-03T04:07:52.723Z",
        "online": {
            "ip_address": "13.232.74.226",
            "user_agent": "amet irure esse"
        }
    }
}
'

Noon

ApplePay & GooglePay

GooglePay

curl --location 'http://localhost:8080/payments' \
--header 'Content-Type: application/json' \
--header 'Accept: application/json' \
--header 'api-key: dev_1h5hh8cuGtbJ21LNolWVJHFqgIygpHk19ZeeTmmbrFcTavrs35F4KhNqbH8fB0S6' \
--data-raw '{
    "amount": 124320,
    "currency": "AED",
    "confirm": true,
    "capture_method": "automatic",
    "capture_on": "2022-09-10T10:11:12Z",
    "customer_id": "CustomerX",
    "email": "[email protected]",
    "name": "John Doe",
    "phone": "999999999",
    "phone_country_code": "+1",
    "description": "Its my first payment request",
    "authentication_type": "no_three_ds",
    "return_url": "https://google.com",
    "payment_method": "wallet",
    "payment_method_type": "google_pay",
    "payment_method_data": {
        "wallet": {
            "google_pay": {
                "type": "CARD",
                "description": "Visa •••• 1111",
                "info": {
                    "card_network": "VISA",
                    "card_details": "1111"
                },
                "tokenization_data": {
                    "type": "PAYMENT_GATEWAY",
                    "token": "{\"signature\":\"MEUCIQDq+hdZFXgAupCk3R5cr9wrDAP/jGPMJkqRsL9pBl8JMQIgA35XbERBWAxupnnSVlVc7yKqTiskRJHfQfWsy8dedLE\\u003d\",\"protocolVersion\":\"ECv1\",\"signedMessage\":\"{\\\"encryptedMessage\\\":\\\"sl3vpO1yFN8a1eYASko9fXRoFsRhGGLMvlewvZxmUhfND29xlG3j4PZAD9Kcov7jd0uP63LNhaZ8iYNkV/6Qwv0j6UfY1IST+HyndIOUQZlN5H6I8hbpvpP5nmjU3gbLnlkk8W5WUp6MAC76keYEW1rRF2qRgLqymYWEWicl9LkDVW6bz0bMuybsqljxaDIp5tGO4dQ9ajV2qwuw4AZx5MA3brKsKjmsJQbe5XIX48rt88yPZDcNQFKfoeo+DCgNpjATIlhIZNZxSue1oBi2can82Fa0+38nM446R8TUwN2pGgTJFqymvIKTZZEtutd8UW1+qCnlogRmyuAfK08QD7OuFFPcVUMiMsYjkS2baHEa9jczpjrBUPbm/DQnHbLkqarsuRqHJ86ZqxMPXMAAato6UsMgwgIeGHAgSWUj0x+e8oQCBm8TGbnIwxsGXlIutIfa9GooIUM1paz+\\\",\\\"ephemeralPublicKey\\\":\\\"BKxNuDGBs2YhCYpcZDWvw4nyo6w95pN2e+V3bfZm/cg8aN1wLHL1KkKceG7LrFkjOFbrO8RDQ3FQ+Yo+CMCtzk0\\\\u003d\\\",\\\"tag\\\":\\\"jbyoC/PCw4pJyK54vvZsL8eqzFOzUVd4hG4qCVHfKN4\\\\u003d\\\"}\"}"
                }
            }
        }
    },
    "billing": {
        "address": {
            "line1": "1467",
            "line2": "Harrison Street",
            "line3": "Harrison Street",
            "city": "San Fransico",
            "state": "Dubai",
            "zip": "94122",
            "country": "AE",
            "first_name": "joseph",
            "last_name": "Doe"
        },
        "phone": {
            "number": "8056594427",
            "country_code": "+97"
        }
    },
    "shipping": {
        "address": {
            "line1": "1467",
            "line2": "Harrison Street",
            "line3": "Harrison Street",
            "city": "San Fransico",
            "state": "California",
            "zip": "94122",
            "country": "AE",
            "first_name": "joseph",
            "last_name": "Doe"
        },
        "phone": {
            "number": "8056594427",
            "country_code": "+91"
        }
    },
    "metadata": {
        "count_tickets": 1,
        "transaction_number": "5590043"
    },
    "customer_acceptance": {
        "acceptance_type": "offline",
        "accepted_at": "1963-05-03T04:07:52.723Z",
        "online": {
            "ip_address": "13.232.74.226",
            "user_agent": "amet irure esse"
        }
    },
        "connector_metadata":{
        "noon":{
            "order_category": "pay"
        }
    }
}
'

Checklist

I formatted the code cargo +nightly fmt --all
I addressed lints thrown by cargo clippy
I reviewed the submitted code
I added unit tests for my changes where possible

…m/juspay/hyperswitch into change_core_amount_to_domain_type

0

…for-payme

crates/router/src/connector/bluesnap.rs

https://github.com/juspay/hyperswitch into 5179-amount-conversion-do-amount-conversion-for-payme

…ay/hyperswitch into iatapay-through-hyperswitch-cypress * 'iatapay-through-hyperswitch-cypress' of github.com:juspay/hyperswitch: feat(router): skip apple pay session call if the browser is not Safari (#5136) fix(opensearch): show search results only if user has access permission to the index (#5097) chore(version): 2024.06.27.0 feat(users): add endpoint for terminate auth select (#5135) feat(users): implemented openidconnect (#5124) feat(router): add payments manual-update api (#5045) fix(docs): open-api fix for payment response (#5103) refactor(connector): [AdyenPlatform]Throw 4xx instead of 5xx for source_balance_account (#4990) feat: realtime user analytics (#5098) refactor(connector): added amount conversion framework for cashtocode (#4857) feat(email): Add `auth_id` in email types and send `auth_id` in email URLs (#5120) refactor(connector): add amount framework to payme & Trustpay with googlePay, ApplePay for bluesnap, Noon & Trustpay (#4833) fix(connector): [BOA/CYBS] make risk information message optional (#5107) chore(version): 2024.06.25.1 fix(router): skip serialize if none for assurance_details_required in googlepay session response (#5118) refactor: separate DB queries and HTML creation for payout links (#4967) feat(router): updated `last_used_at` field for apple pay and google pay for CITs (#5087) fix(payment_methods): use existing field value of `nick_name` in db if not sent during request (#5105) chore(version): 2024.06.25.0

…ay/hyperswitch into refactor-error-handling-in-cypress * 'iatapay-through-hyperswitch-cypress' of github.com:juspay/hyperswitch: chore: clean up feat(router): skip apple pay session call if the browser is not Safari (#5136) fix(opensearch): show search results only if user has access permission to the index (#5097) chore(version): 2024.06.27.0 feat(users): add endpoint for terminate auth select (#5135) feat(users): implemented openidconnect (#5124) feat(router): add payments manual-update api (#5045) fix(docs): open-api fix for payment response (#5103) refactor(connector): [AdyenPlatform]Throw 4xx instead of 5xx for source_balance_account (#4990) feat: realtime user analytics (#5098) refactor(connector): added amount conversion framework for cashtocode (#4857) feat(email): Add `auth_id` in email types and send `auth_id` in email URLs (#5120) refactor(connector): add amount framework to payme & Trustpay with googlePay, ApplePay for bluesnap, Noon & Trustpay (#4833) fix(connector): [BOA/CYBS] make risk information message optional (#5107) chore(version): 2024.06.25.1 fix(router): skip serialize if none for assurance_details_required in googlepay session response (#5118) refactor: separate DB queries and HTML creation for payout links (#4967) feat(router): updated `last_used_at` field for apple pay and google pay for CITs (#5087) fix(payment_methods): use existing field value of `nick_name` in db if not sent during request (#5105) chore(version): 2024.06.25.0

sahkal and others added 30 commits May 13, 2024 16:50

refactor(router): added a new type minor unit to amount

9ef9de9

chore: run formatter

a1bb647

refactor(router): fixed clippy issue

f6c4946

Merge branch 'change_core_amount_to_domain_type' of https://github.co…

937687a

…m/juspay/hyperswitch into change_core_amount_to_domain_type

refactor(router): fixed openapi specs

61850dc

Merge branch 'main' into change_core_amount_to_domain_type

c840348

refactor(router): fixed capture amount unequal bug

6103485

Merge branch 'change_core_amount_to_domain_type' of https://github.co…

0c214b7

…m/juspay/hyperswitch into change_core_amount_to_domain_type

refactor(router): fixed open-api issue

a994132

refactor(router): addressed pr comments

02a7048

refactor(router): resolved merge conflicts

fe6dd36

refactor(router): fixed spell check issue

9852bf4

refactor(router): resolved pr comments:

41af58f

Merge branch 'main' into change_core_amount_to_domain_type

3df68ba

refactor(router): resolved pr comments

6e6726f

Merge branch 'change_core_amount_to_domain_type' of https://github.co…

68034cb

…m/juspay/hyperswitch into change_core_amount_to_domain_type

refactor(router): fixed clippy issue

1b623a8

refactor(router): fixed clippy issue

eff793f

refactor(router): fixed open-api-specs

bce3de0

refactor(router): fixed open-api specs

63ef54c

chore: run formatter

17c58f4

refactor(router): fixed clippy issue

f76ba1d

Merge branch 'change_core_amount_to_domain_type' of https://github.co…

5b657f9

…m/juspay/hyperswitch into change_core_amount_to_domain_type

refactor(router): resolved comments

59ffc34

chore: run formatter

9ba21c4

refactor(router): resolved comments

3bce742

Merge branch 'change_core_amount_to_domain_type' of https://github.co…

5b8cf34

…m/juspay/hyperswitch into change_core_amount_to_domain_type

refactor(router): fixed clippy issue

23e9158

feat(router

78d71ba

0

wip: reduce errors

d4c363f

SamraatBansal previously approved these changes Jun 24, 2024

View reviewed changes

refactor(connector): fixed ci checks failures

1041fbf

sahkal dismissed SamraatBansal’s stale review via 1041fbf June 24, 2024 10:51

sahkal requested a review from SamraatBansal June 24, 2024 11:19

sai-harsha-vardhan previously approved these changes Jun 24, 2024

View reviewed changes

Narayanbhat166 previously approved these changes Jun 24, 2024

View reviewed changes

Sakilmostak previously approved these changes Jun 24, 2024

View reviewed changes

Merge branch 'main' into 5179-amount-conversion-do-amount-conversion-…

d31ce2b

…for-payme

jarnura requested changes Jun 24, 2024

View reviewed changes

crates/router/src/connector/bluesnap.rs Outdated Show resolved Hide resolved

SamraatBansal previously approved these changes Jun 25, 2024

View reviewed changes

sahkal added 2 commits June 25, 2024 13:29

refactor(connector): adderessed pr comments

ccba972

Merge branch '5179-amount-conversion-do-amount-conversion-for-payme' of

b777a3f

https://github.com/juspay/hyperswitch into 5179-amount-conversion-do-amount-conversion-for-payme

sahkal dismissed stale reviews from SamraatBansal, Sakilmostak, sai-harsha-vardhan, and Narayanbhat166 via b777a3f June 25, 2024 08:00

sahkal requested a review from jarnura June 25, 2024 08:00

jarnura approved these changes Jun 25, 2024

View reviewed changes

SamraatBansal approved these changes Jun 26, 2024

View reviewed changes

sai-harsha-vardhan approved these changes Jun 26, 2024

View reviewed changes

Sakilmostak approved these changes Jun 26, 2024

View reviewed changes

ThisIsMani removed the request for review from a team June 26, 2024 09:00

likhinbopanna added this pull request to the merge queue Jun 26, 2024

Merged via the queue into main with commit e69a7bd Jun 26, 2024
11 checks passed

likhinbopanna deleted the 5179-amount-conversion-do-amount-conversion-for-payme branch June 26, 2024 09:30

SanchithHegde removed S-waiting-on-review Status: This PR has been implemented and needs to be reviewed high-risk labels Jun 30, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor(connector): add amount framework to payme & Trustpay with googlePay, ApplePay for bluesnap, Noon & Trustpay #4833

refactor(connector): add amount framework to payme & Trustpay with googlePay, ApplePay for bluesnap, Noon & Trustpay #4833

sahkal commented May 31, 2024 •

edited

Loading

refactor(connector): add amount framework to payme & Trustpay with googlePay, ApplePay for bluesnap, Noon & Trustpay #4833

refactor(connector): add amount framework to payme & Trustpay with googlePay, ApplePay for bluesnap, Noon & Trustpay #4833

Conversation

sahkal commented May 31, 2024 • edited Loading

Type of Change

Description

Additional Changes

Motivation and Context

How did you test it?

Payments Authorise

Refund Flow

Checklist

sahkal commented May 31, 2024 •

edited

Loading