-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(connector): changed amount to minor Unit for stripe #4786
Merged
likhinbopanna
merged 90 commits into
main
from
5177-amount-conversion-do-amount-conversion-for-stripe
Jun 11, 2024
Merged
refactor(connector): changed amount to minor Unit for stripe #4786
likhinbopanna
merged 90 commits into
main
from
5177-amount-conversion-do-amount-conversion-for-stripe
Jun 11, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…m/juspay/hyperswitch into change_core_amount_to_domain_type
…m/juspay/hyperswitch into change_core_amount_to_domain_type
…m/juspay/hyperswitch into change_core_amount_to_domain_type
…m/juspay/hyperswitch into change_core_amount_to_domain_type
…m/juspay/hyperswitch into change_core_amount_to_domain_type
Narayanbhat166
previously approved these changes
Jun 5, 2024
…7-amount-conversion-do-amount-conversion-for-stripe
Narayanbhat166
previously approved these changes
Jun 10, 2024
apoorvdixit88
previously approved these changes
Jun 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dashboard specific changes are fine
jarnura
previously approved these changes
Jun 10, 2024
AkshayaFoiger
previously approved these changes
Jun 10, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Jun 10, 2024
sahkal
dismissed stale reviews from AkshayaFoiger, jarnura, apoorvdixit88, and Narayanbhat166
via
June 10, 2024 09:50
b0894c6
apoorvdixit88
approved these changes
Jun 10, 2024
AkshayaFoiger
approved these changes
Jun 10, 2024
Narayanbhat166
approved these changes
Jun 10, 2024
kashif-m
approved these changes
Jun 10, 2024
jarnura
approved these changes
Jun 10, 2024
likhinbopanna
deleted the
5177-amount-conversion-do-amount-conversion-for-stripe
branch
June 11, 2024 08:12
SanchithHegde
removed
S-waiting-on-review
Status: This PR has been implemented and needs to be reviewed
high-risk
labels
Jun 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
This Pull request Uses the amount framework while sending request to stripe
Note: Stripe works in minor Unit
Additional Changes
Motivation and Context
How did you test it?
Flows to test:
Checklist
cargo +nightly fmt --all
cargo clippy