-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(multitenancy): add support for multitenancy and handle the same in router, producer, consumer, drainer and analytics #4630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jagan-jaya
changed the title
Multitenancy: add tenant id in sessionState and populate it from request header. All component should take tenant_id only from sessionState
feat(multitenancy): add tenant id in sessionState and populate it from request header. All component should take tenant_id only from sessionState
May 13, 2024
…into multitenancy
jagan-jaya
changed the title
feat(multitenancy): add tenant id in sessionState and populate it from request header. All component should take tenant_id only from sessionState
feat(multitenancy): add support for multitenancy and handle the same in router, producer, consumer, drainer and analytics
May 17, 2024
NishantJoshi00
previously approved these changes
May 31, 2024
jarnura
previously approved these changes
May 31, 2024
lsampras
previously approved these changes
May 31, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
analytics changes look good
jagan-jaya
dismissed stale reviews from lsampras, jarnura, and NishantJoshi00
via
June 3, 2024 09:51
d5d5f84
jarnura
previously approved these changes
Jun 3, 2024
Aprabhat19
previously approved these changes
Jun 3, 2024
lsampras
previously approved these changes
Jun 3, 2024
jagan-jaya
dismissed stale reviews from lsampras, Aprabhat19, and jarnura
via
June 3, 2024 11:13
3294ed8
jarnura
approved these changes
Jun 3, 2024
lsampras
approved these changes
Jun 3, 2024
Aprabhat19
approved these changes
Jun 3, 2024
pixincreate
added a commit
that referenced
this pull request
Jun 4, 2024
…atus_pt * 'main' of github.com:juspay/hyperswitch: chore(version): 2024.06.04.0 fix: include client_version and client_source in retried payments (#4826) refactor(users): Changes for Home and Signout APIs for TOTP Redis flows (#4851) feat(users): Create config for TOTP Issuer (#4776) feat(multitenancy): add support for multitenancy and handle the same in router, producer, consumer, drainer and analytics (#4630) feat(connector): [AUTHORIZEDOTNET] Support payment_method_id in recurring mandate payment (#4841) refactor(connector): airwallex convert init payment to preprocessing (#4842) feat(router): send `three_ds_requestor_url` in authentication_response for external 3ds flow (#4828) feat(consolidated-kafka-events): add consolidated kafka payment events (#4798) refactor(connector): [Klarna] Add shipping Address in Klarna Session and Payment Request (#4836) fix(connector): make few fields optional in struct NetceteraErrorDetails (#4827) chore(cypress): remove logs that expose `globalState` (#4844)
pixincreate
added a commit
that referenced
this pull request
Jun 4, 2024
* 'main' of github.com:juspay/hyperswitch: feat(cypress): Add service level testing for Payouts (#4744) feat(auth): Create and use `SinglePurposeOrLoginTokenAuth` (#4830) refactor(connector): [Adyen] handle redirection error response (#4862) refactor(api_models): rename Card struct for payouts to avoid overrides in auto generated open API spec (#4861) chore(version): 2024.06.04.1 fix(connector): [Adyen]add required fields for afterpay clearpay (#4858) chore(version): 2024.06.04.0 fix: include client_version and client_source in retried payments (#4826) refactor(users): Changes for Home and Signout APIs for TOTP Redis flows (#4851) feat(users): Create config for TOTP Issuer (#4776) feat(multitenancy): add support for multitenancy and handle the same in router, producer, consumer, drainer and analytics (#4630) feat(connector): [AUTHORIZEDOTNET] Support payment_method_id in recurring mandate payment (#4841) refactor(connector): airwallex convert init payment to preprocessing (#4842) feat(router): send `three_ds_requestor_url` in authentication_response for external 3ds flow (#4828) feat(consolidated-kafka-events): add consolidated kafka payment events (#4798)
lsampras
reviewed
Jun 6, 2024
Comment on lines
917
to
+920
pub async fn server_wrap_util<'a, 'b, U, T, Q, F, Fut, E, OErr>( | ||
flow: &'a impl router_env::types::FlowMetric, | ||
state: web::Data<AppState>, | ||
incoming_request_header: &HeaderMap, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should skip this else the request headers will be logged by tracing
SanchithHegde
removed
the
S-waiting-on-review
Status: This PR has been implemented and needs to be reviewed
label
Jun 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Additional Changes
Motivation and Context
To establish tenancy in our application and start using the default tenant as 'Hyperswitch' and also offer a 'test' tenant in all environments
How did you test it?
Test for Scheduler
x-tenant-id
as<your-tenant>
in the request header in localhost:8080Test for Drainer
cargo r --bin drainer
x-tenant-id
as<your-tenant>
in the request header in localhost:8080x-tenant-id
as<your-tenant>
in the request header in localhost:8080Test for Redirection
Checklist
cargo +nightly fmt --all
cargo clippy