Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(core): log the appropriate error message if the card fails to get saved in locker #4296

Merged
merged 2 commits into from
Apr 4, 2024
Merged

refactor(core): log the appropriate error message if the card fails to get saved in locker #4296

merged 2 commits into from
Apr 4, 2024

Conversation

Aprabhat19
Copy link
Contributor

@Aprabhat19 Aprabhat19 commented Apr 4, 2024 •
edited
Loading

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

log the appropriate error message if the card fails to get saved in locker

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Cannot be tested , just a log addition

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@Aprabhat19 Aprabhat19 requested a review from a team as a code owner April 4, 2024 09:11
@Aprabhat19 Aprabhat19 self-assigned this Apr 4, 2024
@Aprabhat19 Aprabhat19 linked an issue Apr 4, 2024 that may be closed by this pull request
[Refactor] Log the appropriate error message #4295
Closed
2 tasks
@Aprabhat19 Aprabhat19 added A-core Area: Core flows S-waiting-on-review Status: This PR has been implemented and needs to be reviewed C-refactor Category: Refactor labels Apr 4, 2024
Narayanbhat166
Narayanbhat166 previously approved these changes Apr 4, 2024
View reviewed changes
@Gnanasundari24 Gnanasundari24 added this pull request to the merge queue Apr 4, 2024
Merged via the queue into main with commit 9de3cdb Apr 4, 2024
13 of 15 checks passed
@Gnanasundari24 Gnanasundari24 deleted the log_error branch April 4, 2024 13:00
@SanchithHegde SanchithHegde removed the S-waiting-on-review Status: This PR has been implemented and needs to be reviewed label Apr 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Narayanbhat166 Narayanbhat166 Narayanbhat166 approved these changes

@SanchithHegde SanchithHegde SanchithHegde approved these changes

Assignees

@Aprabhat19 Aprabhat19

Labels
A-core Area: Core flows C-refactor Category: Refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Refactor] Log the appropriate error message
4 participants
@Aprabhat19 @SanchithHegde @Narayanbhat166 @Gnanasundari24