feat(connector): [Ebanx] Add payout flows #4146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sakilmostak
added
A-connector-integration
srujanchikke
previously approved these changes
Apr 26, 2024
SamraatBansal
requested changes
Apr 26, 2024
| let customer_details = item.router_data.request.get_customer_details()?; | ||
|
|
||
| let document_type = pix_data.tax_id.clone().map(|tax_id| { | ||
| if tax_id.clone().expose().len() == 11 { |
There was a problem hiding this comment.
Is this the correct and robust way to deal?
There was a problem hiding this comment.
the tax id comes in a specific format of fixed length, thus, this should be able to handle every cases, you can refer to this article for more info
SamraatBansal
previously approved these changes
Apr 30, 2024
kashif-m
previously approved these changes
Apr 30, 2024
| @@ -483,6 +483,8 @@ pub struct TokenizedBankSensitiveValues { | |||
| pub bic: Option<masking::Secret<String>>, | |||
| pub bank_sort_code: Option<masking::Secret<String>>, | |||
| pub iban: Option<masking::Secret<String>>, | |||
| pub pix_key: Option<masking::Secret<String>>, | |||
There was a problem hiding this comment.
Let's refactor this later.
srujanchikke
previously approved these changes
Apr 30, 2024
Narayanbhat166
previously approved these changes
Apr 30, 2024
crates/api_models/src/payouts.rs
Outdated
| pub pix_key: Secret<String>, | ||
|
|
||
| /// Individual taxpayer identification number | ||
| #[schema(value_type = String, example = "000123456")] |
There was a problem hiding this comment.
Suggested change
| #[schema(value_type = String, example = "000123456")] | |
| #[schema(value_type = Option<String>, example = "000123456")] |
Sakilmostak
dismissed stale reviews from Narayanbhat166, srujanchikke, kashif-m, and SamraatBansal
via
954498e
Narayanbhat166
approved these changes
Apr 30, 2024
srujanchikke
approved these changes
Apr 30, 2024
kashif-m
approved these changes
May 2, 2024
srujanchikke
added a commit
that referenced
this pull request
May 6, 2024
This reverts commit 4f4cbdf.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Payout create, Payout commit and Payout Cancel flows are added to Ebanx
Additional Changes
Motivation and Context
How did you test it?
It is a closed sandbox thus no method is available for testing
Checklist
cargo +nightly fmt --allcargo clippy