Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(payment_methods): add network_transaction_id column in the payment_methods table #4005

Merged
merged 18 commits into from
Apr 3, 2024
Merged

refactor(payment_methods): add network_transaction_id column in the payment_methods table #4005

merged 18 commits into from
Apr 3, 2024

Conversation

ShankarSinghC
Copy link
Contributor

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Add network_transaction_id column in the payment_methods table as it is required to store the NRID against the respective payment_method_id. This NRID will later be used processor agnostic MITs. This pr also adds application level config (network_transactoin_id_supported_connectors) that contains the list of connectors that support the network_transaction_id.

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

columns in the payment_methods table
image

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@ShankarSinghC ShankarSinghC added S-waiting-on-review Status: This PR has been implemented and needs to be reviewed M-database-changes Metadata: This PR involves database schema changes M-configuration-changes Metadata: This PR involves configuration changes A-payment-methods Area: Payment Methods C-refactor Category: Refactor labels Mar 7, 2024
@ShankarSinghC ShankarSinghC self-assigned this Mar 7, 2024
@ShankarSinghC ShankarSinghC requested a review from a team as a code owner March 7, 2024 11:34
This was linked to issues Mar 7, 2024
[FEATURE] Add Application Config and MCA Config to specify setup mandate flow eligibility across payment methods for a connector. #3102
Open
Create a new column in PM table to store NRID #3986
Closed
Creating a domain config (ENV) - nrid_supported_connectors #3998
Closed
This was unlinked from issues Mar 7, 2024
Creating a domain config (ENV) - nrid_supported_connectors #3998
Closed
[FEATURE] Add Application Config and MCA Config to specify setup mandate flow eligibility across payment methods for a connector. #3102
Open
@ShankarSinghC ShankarSinghC linked an issue Mar 7, 2024 that may be closed by this pull request
Creating a domain config (ENV) - nrid_supported_connectors #3998
Closed
@likhinbopanna likhinbopanna added this pull request to the merge queue Apr 3, 2024
Merged via the queue into main with commit 179f5ff Apr 3, 2024
10 of 12 checks passed
@likhinbopanna likhinbopanna deleted the nrid/add-app-config branch April 3, 2024 13:55
@pixincreate pixincreate removed the S-waiting-on-review Status: This PR has been implemented and needs to be reviewed label Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aprabhat19 Aprabhat19 Aprabhat19 approved these changes

@vspecky vspecky vspecky approved these changes

Assignees

@ShankarSinghC ShankarSinghC

Labels
A-payment-methods Area: Payment Methods C-refactor Category: Refactor M-configuration-changes Metadata: This PR involves configuration changes M-database-changes Metadata: This PR involves database schema changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Creating a domain config (ENV) - nrid_supported_connectors Create a new column in PM table to store NRID
5 participants
@ShankarSinghC @vspecky @Aprabhat19 @pixincreate @likhinbopanna