-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core): add core functions for external authentication #3969
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hrithikesh026
added
C-feature
Category: Feature request or enhancement
S-waiting-on-review
Status: This PR has been implemented and needs to be reviewed
labels
Mar 5, 2024
…odules-for-external-authn
…odules-for-external-authn
Base automatically changed from
add-other-prerequisites-for-external-authn
to
main
March 7, 2024 20:10
Please address the refactorings, can be taken up in a separate PR. |
Narayanbhat166
previously approved these changes
Mar 8, 2024
prajjwalkumar17
previously approved these changes
Mar 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! eventhough no Routing changes found in this PR.
SanchithHegde
previously approved these changes
Mar 8, 2024
hrithikesh026
dismissed stale reviews from SanchithHegde, prajjwalkumar17, and Narayanbhat166
via
March 8, 2024 12:22
5448911
SanchithHegde
approved these changes
Mar 8, 2024
prajjwalkumar17
approved these changes
Mar 8, 2024
Narayanbhat166
approved these changes
Mar 8, 2024
SanchithHegde
removed
the
S-waiting-on-review
Status: This PR has been implemented and needs to be reviewed
label
Mar 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Added core functions to take care of pre_authentication, authentication and post_authentication operations.
defined 3 functions
perform_pre_authentication
,perform_authentication
andperform_post_authentication
and other dependencies for these functions.These 3 functions will act as the entry point to the authentication module.
These functions are not being called currently from any flow. That will be done is a separate PR.
Additional Changes
Motivation and Context
To achieve external authentication.
How did you test it?
Compiler guided and Sanity testing to make sure it's backward compatible
This PR cannot be tested until core changes are done.
Checklist
cargo +nightly fmt --all
cargo clippy