Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): add core functions for external authentication #3969

Merged
merged 18 commits into from
Mar 8, 2024

Conversation

hrithikesh026
Copy link
Contributor

@hrithikesh026 hrithikesh026 commented Mar 5, 2024

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Added core functions to take care of pre_authentication, authentication and post_authentication operations.

defined 3 functions perform_pre_authentication, perform_authentication and perform_post_authentication and other dependencies for these functions.

These 3 functions will act as the entry point to the authentication module.

These functions are not being called currently from any flow. That will be done is a separate PR.

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

To achieve external authentication.

How did you test it?

Compiler guided and Sanity testing to make sure it's backward compatible

This PR cannot be tested until core changes are done.

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@hrithikesh026 hrithikesh026 added C-feature Category: Feature request or enhancement S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Mar 5, 2024
@hrithikesh026 hrithikesh026 added this to the February 2024 Release milestone Mar 5, 2024
@hrithikesh026 hrithikesh026 self-assigned this Mar 5, 2024
@hrithikesh026 hrithikesh026 requested review from a team as code owners March 5, 2024 18:02
Base automatically changed from add-other-prerequisites-for-external-authn to main March 7, 2024 20:10
@hrithikesh026 hrithikesh026 requested review from a team as code owners March 7, 2024 20:10
@Narayanbhat166
Copy link
Member

Please address the refactorings, can be taken up in a separate PR.

Narayanbhat166
Narayanbhat166 previously approved these changes Mar 8, 2024
prajjwalkumar17
prajjwalkumar17 previously approved these changes Mar 8, 2024
Copy link
Contributor

@prajjwalkumar17 prajjwalkumar17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! eventhough no Routing changes found in this PR.

SanchithHegde
SanchithHegde previously approved these changes Mar 8, 2024
crates/cards/src/validate.rs Outdated Show resolved Hide resolved
crates/router/src/core/authentication.rs Outdated Show resolved Hide resolved
crates/router/src/types/api/authentication.rs Outdated Show resolved Hide resolved
@Gnanasundari24 Gnanasundari24 added this pull request to the merge queue Mar 8, 2024
Merged via the queue into main with commit 897e264 Mar 8, 2024
13 of 15 checks passed
@Gnanasundari24 Gnanasundari24 deleted the core-modules-for-external-authn branch March 8, 2024 14:00
@SanchithHegde SanchithHegde removed the S-waiting-on-review Status: This PR has been implemented and needs to be reviewed label Mar 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-feature Category: Feature request or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants