Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(core): Status mapping for Capture for 429 http code #3897

Merged
merged 1 commit into from
Feb 29, 2024
Merged

refactor(core): Status mapping for Capture for 429 http code #3897

merged 1 commit into from
Feb 29, 2024

Conversation

Sakilmostak
Copy link
Contributor

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Status should remain same to previous status in case of 429 http code

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

This error cannot be tested in sandbox so not included

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@Sakilmostak Sakilmostak added A-connector-integration Area: Connector integration C-refactor Category: Refactor labels Feb 29, 2024
@Sakilmostak Sakilmostak self-assigned this Feb 29, 2024
@Sakilmostak Sakilmostak requested review from a team as code owners February 29, 2024 11:48
@Gnanasundari24 Gnanasundari24 added this pull request to the merge queue Feb 29, 2024
Merged via the queue into main with commit 9b5f26a Feb 29, 2024
10 of 12 checks passed
@Gnanasundari24 Gnanasundari24 deleted the status_mapping_429 branch February 29, 2024 18:34
@Sakilmostak Sakilmostak mentioned this pull request Mar 1, 2024
Merged
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Narayanbhat166 Narayanbhat166 Narayanbhat166 approved these changes

@ArjunKarthik ArjunKarthik ArjunKarthik approved these changes

Assignees

@Sakilmostak Sakilmostak

Labels
A-connector-integration Area: Connector integration C-refactor Category: Refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Sakilmostak @ArjunKarthik @Narayanbhat166 @Gnanasundari24