fix(core): return surcharge in payment method list response if passed in create request #3363
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
If merchant sends surcharge details in payment create call(to override surcharge calculation), we wouldn't send any surcharge details in
list payment method
call since surcharge won't be generated in this case.In this PR, I have made some refactors to return surcharge_details against each payment method type in
list payment method call
even if merchant chooses to override surcharge calculation by sending surcharge details in payments create call.Additional Changes
Motivation and Context
How did you test it?
Manual
Payment Create with surcharge
Payment method list
Checklist
cargo +nightly fmt --all
cargo clippy