feat(connector): [BANKOFAMERICA] Implement 3DS flow for cards #3343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deepanshu-iiitu
added
A-connector-integration
2 tasks
SamraatBansal
previously approved these changes
Jan 12, 2024
srujanchikke
requested changes
Jan 14, 2024
srujanchikke
previously approved these changes
Jan 16, 2024
srujanchikke
previously approved these changes
Jan 16, 2024
SamraatBansal
previously approved these changes
Jan 16, 2024
crates/router/src/services/api.rs
Outdated
| @@ -786,6 +786,15 @@ pub enum RedirectForm { | |||
| Html { | |||
| html_data: String, | |||
| }, | |||
| BankOfAmericaAuthSetup { | |||
There was a problem hiding this comment.
Let's use CybersourceAuthSetup & CybersourceConsumerAuth
Comment on lines
+461
to
+462
| let email = item.router_data.request.get_email()?; | ||
| let bill_to = build_bill_to(item.router_data.get_billing()?, email)?; |
There was a problem hiding this comment.
Do we need this to be added in dynamic fields? since this is for 3ds?
There was a problem hiding this comment.
These fields are required in authorize call (even for 3ds). If we not pass these fields the connector is throwing missing field error.
deepanshu-iiitu
dismissed stale reviews from SamraatBansal and srujanchikke
via
113890c
ArjunKarthik
approved these changes
Jan 16, 2024
Narayanbhat166
approved these changes
Jan 16, 2024
SamraatBansal
approved these changes
Jan 16, 2024
srujanchikke
approved these changes
Jan 16, 2024
pixincreate
added a commit
that referenced
this pull request
Jan 17, 2024
* 'main' of github.com:juspay/hyperswitch: chore(version): 2024.01.17.0 feat(connector): [BANKOFAMERICA] Implement 3DS flow for cards (#3343) ci(s3): fetch connector creds from s3 for added security (#3323) feat(recon): add recon APIs (#3345) fix(payment_link): added expires_on in payment response (#3332) fix(connector_onboarding): Check if connector exists for the merchant account and add reset tracking id API (#3229)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Implement 3DS flow for cards
Additional Changes
Motivation and Context
#3342
How did you test it?
QA Testing
All the possible 3DS test cases and test cards are available here: https://developer.cybersource.com/content/dam/docs/cybs/en-us/payer-authentication/developer/all/rest/payer-auth.pdf
3DS Payment Curl:
curl --location 'http://localhost:8080/payments' \ --header 'Content-Type: application/json' \ --header 'Accept: application/json' \ --header 'api-key: API_KEY_HERE' \ --data-raw '{ "amount": 1404, "currency": "USD", "confirm": true, "capture_method": "automatic", "capture_on": "2022-09-10T10:11:12Z", "customer_id": "CustomerX", "email": "[email protected]", "name": "John Doe", "phone": "999999999", "phone_country_code": "+1", "description": "Its my first payment request", "authentication_type": "three_ds", "return_url": "https://google.com", "payment_method": "card", "payment_method_type": "credit", "payment_method_data": { "card": { "card_number": "340000000001098", "card_exp_month": "12", "card_exp_year": "30", "card_holder_name": "joseph", "card_cvc": "123" } }, "billing": { "address": { "line1": "sdv", "line2": "Harrison Street", "line3": "Harrison Street", "city": "San Fransico", "state": "California", "zip": "46282", "country": "US", "first_name": "joseph", "last_name": "ewcjwd" }, "phone": { "number": "8056594427", "country_code": "+97" } }, "statement_descriptor_name": "joseph", "statement_descriptor_suffix": "JS", "metadata": { "count_tickets": "1", "transaction_number": 2233 }, "business_label": "food", "business_country": "US" }'Checklist
cargo +nightly fmt --allcargo clippy