Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(core): restrict requires_customer_action in confirm #3235

Merged
merged 2 commits into from
Jan 30, 2024
Merged

refactor(core): restrict requires_customer_action in confirm #3235

merged 2 commits into from
Jan 30, 2024

Conversation

Narayanbhat166
Copy link
Member

Type of Change

  • Refactoring

Description

This PR will restrict a payment to be confirmed again if the status is requires_customer_action.

Motivation and Context

A payment which is in requires_customer_action cannot be confirmed again. Only failed payments can be retried by passing retry_action as retry.

How did you test it?

  • Confirm a payment which is in requires_customer_action state.
Screenshot 2024-01-03 at 7 09 41 PM
  • Create sepa bank transfer payment via stripe ( payments_confirm happens via webhooks )
Screenshot 2024-01-03 at 8 46 11 PM
  • Payment updated by charged webhook
Screenshot 2024-01-03 at 8 47 38 PM

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code

@Narayanbhat166 Narayanbhat166 added A-core Area: Core flows S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Jan 3, 2024
@Narayanbhat166 Narayanbhat166 added this to the December 2023 Release milestone Jan 3, 2024
@Narayanbhat166 Narayanbhat166 self-assigned this Jan 3, 2024
@Narayanbhat166 Narayanbhat166 requested review from a team as code owners January 3, 2024 15:20
@github-actions github-actions bot added the S-conventions-not-followed Status: This PR does not follow contributing guidelines label Jan 3, 2024
@Narayanbhat166 Narayanbhat166 changed the title refactor(: restrict requires_customer_action in confirm refactor(core): restrict requires_customer_action in confirm Jan 4, 2024
@github-actions github-actions bot removed the S-conventions-not-followed Status: This PR does not follow contributing guidelines label Jan 4, 2024
@Gnanasundari24
Copy link
Contributor

@Narayanbhat166 Can you add the testcases in Postman collection aswell.

@Gnanasundari24 Gnanasundari24 added this pull request to the merge queue Jan 30, 2024
Merged via the queue into main with commit d2accde Jan 30, 2024
10 checks passed
@Gnanasundari24 Gnanasundari24 deleted the restrict_customer_action branch January 30, 2024 12:10
@Narayanbhat166 Narayanbhat166 mentioned this pull request Jan 30, 2024
Merged
5 tasks
@SanchithHegde SanchithHegde removed the S-waiting-on-review Status: This PR has been implemented and needs to be reviewed label Feb 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sai-harsha-vardhan sai-harsha-vardhan sai-harsha-vardhan approved these changes

@vspecky vspecky vspecky approved these changes

@jarnura jarnura jarnura approved these changes

Assignees

@Narayanbhat166 Narayanbhat166

Labels
A-core Area: Core flows
Projects
None yet
Milestone
December 2023 Release
Development

Successfully merging this pull request may close these issues.
6 participants
@Narayanbhat166 @Gnanasundari24 @jarnura @vspecky @sai-harsha-vardhan @SanchithHegde