Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pm_auth): Support different pm types in PM auth #3114

Merged
merged 14 commits into from
Mar 15, 2024

Conversation

Sarthak1799
Copy link
Contributor

@Sarthak1799 Sarthak1799 commented Dec 12, 2023

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Support for SEPA and BACS in direct debit PM auth.
Earlier we only supported ACH based response from pm auth connector in PM auth, now have added support for BACS and SEPA based responses as well.

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Have tested locally by hardcoding response from connector. This cannot be tested as it is in sandbox because Plaid always sends a basic ACH based response in sandbox which won't trigger the response structure for BACS and SEPA (the implementation of this PR).
A simple sanity testing however can be done for the feature, refer to this for testing instructions - #3047

image image

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@Sarthak1799 Sarthak1799 added the C-feature Category: Feature request or enhancement label Dec 12, 2023
@Sarthak1799 Sarthak1799 self-assigned this Dec 12, 2023
@Sarthak1799 Sarthak1799 requested review from a team as code owners December 12, 2023 10:21
crates/pm_auth/src/types.rs Outdated Show resolved Hide resolved
crates/router/src/core/payment_methods/cards.rs Outdated Show resolved Hide resolved
crates/router/src/core/pm_auth.rs Outdated Show resolved Hide resolved
@Sarthak1799 Sarthak1799 linked an issue Feb 9, 2024 that may be closed by this pull request
2 tasks
crates/api_models/src/payment_methods.rs Show resolved Hide resolved
crates/router/src/core/pm_auth.rs Outdated Show resolved Hide resolved
@Gnanasundari24 Gnanasundari24 added this pull request to the merge queue Mar 15, 2024
Merged via the queue into main with commit 290c456 Mar 15, 2024
13 of 15 checks passed
@Gnanasundari24 Gnanasundari24 deleted the generic-pm-auth branch March 15, 2024 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-feature Category: Feature request or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Make PM auth service generic across Payment Method types
4 participants