-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(router): add support for googlepay step up flow #2744
Conversation
…uspay/hyperswitch into add-assurance-details-in-gpay-metadata
Please fix the openapi check |
if !assurance_details.card_holder_authenticated | ||
|| !assurance_details.account_verified | ||
{ | ||
self.auth_type = diesel_models::enums::AuthenticationType::ThreeDs; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you add a comment here to inform that 3ds has been stepped up
if !assurance_details.card_holder_authenticated | ||
|| !assurance_details.account_verified | ||
{ | ||
self.auth_type = diesel_models::enums::AuthenticationType::ThreeDs; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same here, can you add a comment here to inform that 3ds has been stepped up?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same here, can you add a comment here to inform that 3ds has been stepped up?
I meant logs in this case
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed connector changes.
…ough-hyperswitch-cypress * 'main' of github.com:juspay/hyperswitch: feat(router): add support for googlepay step up flow (#2744) fix(access_token): use `merchant_connector_id` in access token (#5106) feat: added kafka events for authentication create and update (#4991) feat(ci): add vector to handle logs pipeline (#5021) feat(users): Decision manager flow changes for SSO (#4995) ci(cypress): Fix payment method id for non supported connectors (#5075) refactor(core): introduce an interface to switch between old and new connector integration implementations on the connectors (#5013) refactor(events): populate object identifiers in outgoing webhooks analytics events during retries (#5067) Refactor: [Fiserv] Remove Default Case Handling (#4767) chore(version): 2024.06.24.0 fix(router): avoid considering pre-routing results during `perform_session_token_routing` (#5076) refactor(redis): spawn one subscriber thread for handling all the published messages to different channel (#5064) feat(users): setup user authentication methods schema and apis (#4999) feat(payment_methods): Implement Process tracker workflow for Payment method Status update (#4668) chore(version): 2024.06.20.1 chore(postman): update Postman collection files fix(payment_methods): support last used for off session token payments (#5039) ci(postman): add net_amount field test cases (#3286) refactor(connector): [Mifinity]dynamic fields for mifinity (#5056) refactor(payment_method): [Klarna] store and populate payment_type for klarna_sdk Paylater in response (#4956)
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Prasunna Soppa <[email protected]> Co-authored-by: Prasunna Soppa <[email protected]> Co-authored-by: sai-harsha-vardhan <[email protected]> Co-authored-by: hyperswitch-bot[bot] <148525504+hyperswitch-bot[bot]@users.noreply.github.com>
Type of Change
Description
add support for googlepay step up flow
Additional Changes
Motivation and Context
When given as true, this field motivates stripe to include verification results in the session token flow. If the verification is failed here, we want to detect it and step up the payment to a 3DS payment.
How did you test it?
Tested Manually
Payments Create CURL
Payments Confirm CURL with google_pay payment_method assurance_details
Create a payment with authentication_type as no_three_ds, then make a googlepay payment with card_holder_authenticated as false and observe the payment has been forced to authentication_type three_ds
Create a payment with authentication_type as no_three_ds, when both card_holder_authenticated and account_verified are true, it'll proceed with no_three_ds without step up
Checklist
cargo +nightly fmt --all
cargo clippy