-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(payment_methods): Added support for pm_auth_connector field in pm list response #2667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sarthak1799
added
S-waiting-on-review
Status: This PR has been implemented and needs to be reviewed
A-payment-methods
Area: Payment Methods
C-refactor
Category: Refactor
labels
Oct 23, 2023
Chethan-rao
reviewed
Oct 23, 2023
Co-authored-by: Chethan Rao <[email protected]>
Chethan-rao
previously approved these changes
Oct 25, 2023
vspecky
previously approved these changes
Oct 27, 2023
vspecky
added
the
M-api-contract-changes
Metadata: This PR involves API contract changes
label
Oct 27, 2023
Chethan-rao
approved these changes
Oct 27, 2023
jarnura
approved these changes
Nov 16, 2023
vspecky
approved these changes
Nov 20, 2023
SanchithHegde
removed
the
S-waiting-on-review
Status: This PR has been implemented and needs to be reviewed
label
Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-payment-methods
Area: Payment Methods
C-refactor
Category: Refactor
M-api-contract-changes
Metadata: This PR involves API contract changes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Added pm_auth_connector in pm merchant list response as to check the existence of a configured pm_auth connector for a particular payment method type.
Additional Changes
Motivation and Context
How did you test it?
Checklist
cargo +nightly fmt --all
cargo clippy