Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(router): remove the payment type column in payment intent #2462

Merged
merged 2 commits into from
Oct 5, 2023
Merged

refactor(router): remove the payment type column in payment intent #2462

merged 2 commits into from
Oct 5, 2023

Conversation

vspecky
Copy link
Member

@vspecky vspecky commented Oct 5, 2023

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

This PR removes the payment_type column from the payment_intent table.

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

The payment_type can be inferred from data already present in the payment attempt so storing it is no longer a requirement.

How did you test it?

Local, compiler-guided

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@vspecky vspecky added A-core Area: Core flows S-waiting-on-review Status: This PR has been implemented and needs to be reviewed C-refactor Category: Refactor R-waiting-on-L1 Review: Waiting on L1 reviewer R-waiting-on-L2 Review: Waiting on L2 reviewer A-payments Area: payments labels Oct 5, 2023
@vspecky vspecky added this to the September 2023 Milestone milestone Oct 5, 2023
@vspecky vspecky requested a review from a team as a code owner October 5, 2023 13:10
@vspecky vspecky self-assigned this Oct 5, 2023
@vspecky vspecky requested a review from a team as a code owner October 5, 2023 13:10
@vspecky vspecky added the M-database-changes Metadata: This PR involves database schema changes label Oct 5, 2023
jarnura
jarnura previously approved these changes Oct 5, 2023
View reviewed changes
@ArjunKarthik ArjunKarthik added S-waiting-on-review Status: This PR has been implemented and needs to be reviewed and removed R-waiting-on-L1 Review: Waiting on L1 reviewer R-waiting-on-L2 Review: Waiting on L2 reviewer S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Oct 5, 2023
@jarnura jarnura added this pull request to the merge queue Oct 5, 2023
Merged via the queue into main with commit 980aa44 Oct 5, 2023
10 checks passed
@jarnura jarnura deleted the remove-payment-type-column-from-payment-intent branch October 5, 2023 15:35
@SanchithHegde SanchithHegde removed the S-waiting-on-review Status: This PR has been implemented and needs to be reviewed label Oct 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Narayanbhat166 Narayanbhat166 Narayanbhat166 approved these changes

@jarnura jarnura jarnura approved these changes

@ArjunKarthik ArjunKarthik ArjunKarthik approved these changes

Assignees

@vspecky vspecky

Labels
A-core Area: Core flows A-payments Area: payments C-refactor Category: Refactor M-database-changes Metadata: This PR involves database schema changes
Projects
No open projects
hyperswitch - Public Roadmap
Status: Merged
Milestone
September 2023 Milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@vspecky @ArjunKarthik @jarnura @Narayanbhat166 @SanchithHegde