Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(router): add support for payment_type field in payment intent #2448

Merged
merged 10 commits into from
Oct 5, 2023

Conversation

vspecky
Copy link
Member

@vspecky vspecky commented Oct 4, 2023

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

This PR adds a new payment_type column in the payment_intent table, the value of which is inferred during payment creation, and is also included in the response of the list payment methods call.

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

The payment_type field will be detrimental in deciding the right mandate flow. Certain merchants may want to just set up the mandate without debiting any amount, whereas some merchants may want to debit some amount as part of the setup. This distinction is done based on the payment_type.

How did you test it?

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@vspecky vspecky added A-core Area: Core flows C-feature Category: Feature request or enhancement S-waiting-on-review Status: This PR has been implemented and needs to be reviewed A-payment-methods Area: Payment Methods R-waiting-on-L1 Review: Waiting on L1 reviewer A-payments Area: payments labels Oct 4, 2023
@vspecky vspecky added this to the September 2023 Milestone milestone Oct 4, 2023
@vspecky vspecky requested a review from a team as a code owner October 4, 2023 13:47
@vspecky vspecky self-assigned this Oct 4, 2023
@vspecky vspecky requested a review from a team as a code owner October 4, 2023 13:47
@vspecky vspecky requested a review from a team as a code owner October 4, 2023 15:05
@vspecky vspecky requested a review from jarnura October 5, 2023 09:24
@Narayanbhat166 Narayanbhat166 added this pull request to the merge queue Oct 5, 2023
Merged via the queue into main with commit f116728 Oct 5, 2023
10 checks passed
@Narayanbhat166 Narayanbhat166 deleted the add-payment-type-enum-support branch October 5, 2023 11:10
@vspecky vspecky added M-database-changes Metadata: This PR involves database schema changes M-api-contract-changes Metadata: This PR involves API contract changes labels Oct 5, 2023
@SanchithHegde SanchithHegde removed S-waiting-on-review Status: This PR has been implemented and needs to be reviewed R-waiting-on-L1 Review: Waiting on L1 reviewer labels Oct 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-core Area: Core flows A-payment-methods Area: Payment Methods A-payments Area: payments C-feature Category: Feature request or enhancement M-api-contract-changes Metadata: This PR involves API contract changes M-database-changes Metadata: This PR involves database schema changes
Projects
No open projects
Status: Merged
Development

Successfully merging this pull request may close these issues.

4 participants