-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(router): add support for payment_type field in payment intent #2448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vspecky
added
A-core
Area: Core flows
C-feature
Category: Feature request or enhancement
S-waiting-on-review
Status: This PR has been implemented and needs to be reviewed
A-payment-methods
Area: Payment Methods
R-waiting-on-L1
Review: Waiting on L1 reviewer
A-payments
Area: payments
labels
Oct 4, 2023
migrations/2023-10-04-120026_add_payment_type_column_in_payment_intent/up.sql
Outdated
Show resolved
Hide resolved
jarnura
requested changes
Oct 5, 2023
…stead of relying on the optional amount in the request
Narayanbhat166
approved these changes
Oct 5, 2023
jarnura
approved these changes
Oct 5, 2023
vspecky
added
M-database-changes
Metadata: This PR involves database schema changes
M-api-contract-changes
Metadata: This PR involves API contract changes
labels
Oct 5, 2023
SanchithHegde
removed
S-waiting-on-review
Status: This PR has been implemented and needs to be reviewed
R-waiting-on-L1
Review: Waiting on L1 reviewer
labels
Oct 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-core
Area: Core flows
A-payment-methods
Area: Payment Methods
A-payments
Area: payments
C-feature
Category: Feature request or enhancement
M-api-contract-changes
Metadata: This PR involves API contract changes
M-database-changes
Metadata: This PR involves database schema changes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
This PR adds a new
payment_type
column in thepayment_intent
table, the value of which is inferred during payment creation, and is also included in the response of the list payment methods call.Additional Changes
Motivation and Context
The
payment_type
field will be detrimental in deciding the right mandate flow. Certain merchants may want to just set up the mandate without debiting any amount, whereas some merchants may want to debit some amount as part of the setup. This distinction is done based on thepayment_type
.How did you test it?
Checklist
cargo +nightly fmt --all
cargo clippy