Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(payment_methods): add requires_cvv config while creating merchant account #2431

Merged
merged 17 commits into from
Oct 4, 2023
Merged

refactor(payment_methods): add requires_cvv config while creating merchant account #2431

merged 17 commits into from
Oct 4, 2023

Conversation

Chethan-rao
Copy link
Contributor

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

This PR includes changes for inserting requires_cvv config during merchant account creation itself. while getting that config during list_customer_payment_method, if not found in db, we insert it into db.

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

image

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@Chethan-rao
refactor(masking): move masking implementations to masking crate
a3e2b79
@Chethan-rao
Merge branch 'main' of github.com:juspay/hyperswitch
a621192
@Chethan-rao
t Merge branch 'main' of github.com:juspay/hyperswitch
b1bc6c7
@Chethan-rao
Merge branch 'main' of github.com:juspay/hyperswitch
9623ec8
@Chethan-rao
Merge branch 'main' of github.com:juspay/hyperswitch
0333593
@Chethan-rao
Merge branch 'main' of github.com:juspay/hyperswitch
587549f
@Chethan-rao
Merge branch 'main' of github.com:juspay/hyperswitch
57b3aad
@Chethan-rao
Merge branch 'main' of github.com:juspay/hyperswitch
687a4f2
@Chethan-rao
Merge branch 'main' of github.com:juspay/hyperswitch
9e8ce1f
@Chethan-rao
Merge branch 'main' of github.com:juspay/hyperswitch
06132d5
@Chethan-rao
Merge branch 'main' of github.com:juspay/hyperswitch
d06624c
@Chethan-rao
Merge branch 'main' of github.com:juspay/hyperswitch
c1ef143
@Chethan-rao
refactor: add requires_cvv config while creating merchant account
b6bab27
@Chethan-rao Chethan-rao added S-waiting-on-review Status: This PR has been implemented and needs to be reviewed A-payment-methods Area: Payment Methods C-refactor Category: Refactor labels Oct 3, 2023
@Chethan-rao Chethan-rao added this to the September 2023 Milestone milestone Oct 3, 2023
@Chethan-rao Chethan-rao requested a review from a team as a code owner October 3, 2023 13:39
@Chethan-rao Chethan-rao self-assigned this Oct 3, 2023
@Chethan-rao Chethan-rao linked an issue Oct 3, 2023 that may be closed by this pull request
[FEATURE] add requires_cvv field to customer payment method list api object #1854
Closed
2 tasks
@Chethan-rao Chethan-rao removed a link to an issue Oct 3, 2023
[FEATURE] add requires_cvv field to customer payment method list api object #1854
Closed
2 tasks
@Chethan-rao Chethan-rao linked an issue Oct 3, 2023 that may be closed by this pull request
[REFACTOR] add requires_cvv config while creating merchant account #2432
Closed
2 tasks
Abhicodes-crypto
Abhicodes-crypto suggested changes Oct 3, 2023
View reviewed changes
crates/router/src/core/admin.rs Outdated Show resolved Hide resolved
Abhicodes-crypto
Abhicodes-crypto suggested changes Oct 4, 2023
View reviewed changes
crates/router/src/core/admin.rs Outdated Show resolved Hide resolved
@Narayanbhat166 Narayanbhat166 added this pull request to the merge queue Oct 4, 2023
Merged via the queue into main with commit 6e5ab0d Oct 4, 2023
10 checks passed
@Narayanbhat166 Narayanbhat166 deleted the refactor_requires_cvv branch October 4, 2023 12:14
@SanchithHegde SanchithHegde removed the S-waiting-on-review Status: This PR has been implemented and needs to be reviewed label Oct 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Abhicodes-crypto Abhicodes-crypto Abhicodes-crypto approved these changes

@Narayanbhat166 Narayanbhat166 Narayanbhat166 approved these changes

Assignees

@Chethan-rao Chethan-rao

Labels
A-payment-methods Area: Payment Methods C-refactor Category: Refactor
Projects
No open projects
hyperswitch - Public Roadmap
Status: Merged
Milestone
September 2023 Milestone
Development

Successfully merging this pull request may close these issues.

[REFACTOR] add requires_cvv config while creating merchant account
4 participants
@Chethan-rao @Narayanbhat166 @Abhicodes-crypto @SanchithHegde