Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: temp support for ach gocardless with existing api contracts #2395

Merged
merged 2 commits into from
Sep 29, 2023
Merged

fix: temp support for ach gocardless with existing api contracts #2395

merged 2 commits into from
Sep 29, 2023

Conversation

ArjunKarthik
Copy link
Contributor

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

temp support for ach gocardless with existing api contracts

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Local testing with postman

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@ArjunKarthik ArjunKarthik added A-connector-integration Area: Connector integration S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Sep 29, 2023
@ArjunKarthik ArjunKarthik self-assigned this Sep 29, 2023
@ArjunKarthik ArjunKarthik requested a review from a team as a code owner September 29, 2023 13:12
@ArjunKarthik ArjunKarthik added S-ready-for-merge and removed S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Sep 29, 2023
@ArjunKarthik ArjunKarthik added this pull request to the merge queue Sep 29, 2023
Merged via the queue into main with commit d43fbcc Sep 29, 2023
20 checks passed
@ArjunKarthik ArjunKarthik deleted the gocardless-req-changes branch September 29, 2023 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srujanchikke srujanchikke srujanchikke approved these changes

@tinu-hareesswar tinu-hareesswar tinu-hareesswar approved these changes

Assignees

@ArjunKarthik ArjunKarthik

Labels
A-connector-integration Area: Connector integration
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ArjunKarthik @tinu-hareesswar @srujanchikke @SanchithHegde