Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(router): add profile id and extra filters in lists #2379

Merged
merged 7 commits into from
Oct 4, 2023
Merged

feat(router): add profile id and extra filters in lists #2379

merged 7 commits into from
Oct 4, 2023

Conversation

apoorvdixit88
Copy link
Contributor

@apoorvdixit88 apoorvdixit88 commented Sep 27, 2023 •
edited
Loading

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

  • Added profile id filter in payments, refunds, and disputes list
  • Added more filters in Payments list

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

  • Profile id search need to be present in payments, refunds and disputes list.
  • More payments list filters is a merchant requirement.

How did you test it?

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@apoorvdixit88 apoorvdixit88 added M-api-contract-changes Metadata: This PR involves API contract changes A-refunds Area: Refund flows A-disputes Area: Dispute flows A-payments Area: payments labels Sep 27, 2023
@apoorvdixit88 apoorvdixit88 requested a review from a team as a code owner September 27, 2023 07:48
@apoorvdixit88 apoorvdixit88 self-assigned this Sep 27, 2023
@apoorvdixit88 apoorvdixit88 requested a review from a team as a code owner September 27, 2023 07:48
@apoorvdixit88 apoorvdixit88 requested a review from a team as a code owner September 27, 2023 09:40
@apoorvdixit88 apoorvdixit88 added S-waiting-on-review Status: This PR has been implemented and needs to be reviewed R-waiting-on-L1 Review: Waiting on L1 reviewer labels Sep 27, 2023
@apoorvdixit88 apoorvdixit88 added R-waiting-on-L2 Review: Waiting on L2 reviewer and removed R-waiting-on-L1 Review: Waiting on L1 reviewer labels Oct 4, 2023
@SanchithHegde SanchithHegde added this pull request to the merge queue Oct 4, 2023
@SanchithHegde SanchithHegde removed S-waiting-on-review Status: This PR has been implemented and needs to be reviewed R-waiting-on-L2 Review: Waiting on L2 reviewer labels Oct 4, 2023
Merged via the queue into main with commit ab2cde7 Oct 4, 2023
11 of 17 checks passed
@SanchithHegde SanchithHegde deleted the add-more-filters-in-list-payments-refunds branch October 4, 2023 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThisIsMani ThisIsMani ThisIsMani approved these changes

@Narayanbhat166 Narayanbhat166 Narayanbhat166 approved these changes

@SanchithHegde SanchithHegde SanchithHegde approved these changes

@lsampras lsampras Awaiting requested review from lsampras

@racnan racnan Awaiting requested review from racnan

Assignees

@apoorvdixit88 apoorvdixit88

Labels
A-disputes Area: Dispute flows A-payments Area: payments A-refunds Area: Refund flows M-api-contract-changes Metadata: This PR involves API contract changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@apoorvdixit88 @SanchithHegde @Narayanbhat166 @ThisIsMani