Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: enable logs feature flag in router crate #2358

Merged
merged 9 commits into from
Sep 25, 2023
Merged

refactor: enable logs feature flag in router crate #2358

merged 9 commits into from
Sep 25, 2023

Conversation

Chethan-rao
Copy link
Contributor

@Chethan-rao Chethan-rao commented Sep 24, 2023 •
edited
Loading

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

This PR includes changes for enabling logs feature flag in router crate for enabling logs for connector_request_body

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

image

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@Chethan-rao Chethan-rao added S-waiting-on-review Status: This PR has been implemented and needs to be reviewed C-refactor Category: Refactor labels Sep 24, 2023
@Chethan-rao Chethan-rao added this to the September 2023 Milestone milestone Sep 24, 2023
@Chethan-rao Chethan-rao requested a review from a team as a code owner September 24, 2023 08:10
@Chethan-rao Chethan-rao self-assigned this Sep 24, 2023
@Chethan-rao Chethan-rao changed the title refactor: remove logging for connector_request_body from being under feature flag refactor: enable logs feature flag in router crate Sep 24, 2023
@vspecky vspecky added A-dependencies Area: Dependencies C-bug Category: Bug R-waiting-on-L2 Review: Waiting on L2 reviewer R-L1-completed Review: L1 Review completed labels Sep 25, 2023
@vspecky vspecky added this pull request to the merge queue Sep 25, 2023
Merged via the queue into main with commit e4af381 Sep 25, 2023
8 of 10 checks passed
@vspecky vspecky deleted the fix_request_body_refactor branch September 25, 2023 07:40
@SanchithHegde SanchithHegde removed S-waiting-on-review Status: This PR has been implemented and needs to be reviewed R-waiting-on-L2 Review: Waiting on L2 reviewer R-L1-completed Review: L1 Review completed labels Sep 25, 2023
Chethan-rao added a commit that referenced this pull request Sep 27, 2023
@Chethan-rao @vspecky
refactor: enable logs feature flag in router crate (#2358)
339fd3d 
Co-authored-by: ItsMeShashank <[email protected]>
@Chethan-rao Chethan-rao mentioned this pull request Sep 27, 2023
Merged
15 tasks
vspecky added a commit that referenced this pull request Sep 27, 2023
@Chethan-rao @vspecky
refactor: enable logs feature flag in router crate (#2358) (#2382)
5cefda0 
Co-authored-by: ItsMeShashank <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Narayanbhat166 Narayanbhat166 Narayanbhat166 approved these changes

@vspecky vspecky vspecky approved these changes

@SanchithHegde SanchithHegde Awaiting requested review from SanchithHegde

Assignees

@Chethan-rao Chethan-rao

Labels
A-dependencies Area: Dependencies C-bug Category: Bug C-refactor Category: Refactor
Projects
None yet
Milestone
September 2023 Milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Chethan-rao @vspecky @Narayanbhat166 @SanchithHegde